1308868 - [Static Analysis][Clang-Plugin] Ignore class members initialisation check - wave 2

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

This is wave 2 - for Bug 1282408

As for some member variables we want to ignore it's initialisation check performed by clang-plugin - https://bugzilla.mozilla.org/show_bug.cgi?id=525063
We've added a flag for the declaration of each variable that we want to be ignored.
On this bug there will be posted patches of this kind.

Comment 1

[Andi [:andi]]

Attachment: Bug 1308868 - Add ignore-initialization-check annotation to members from TriangleTyped.

Review commit: https://reviewboard.mozilla.org/r/84544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84544/

Comment 2

[Andi [:andi]]

Comment on attachment 8799342 [details]
Bug 1308868 - Add ignore-initialization-check annotation to members from TriangleTyped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84544/diff/1-2/

Comment 3

[Andi [:andi]]

Attachment: Bug 1308868 - Add ignore-initialization-check annotation to mPendingTextTrackChange from TextTrackList.

Review commit: https://reviewboard.mozilla.org/r/84888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84888/

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8799765 [details]
Bug 1308868 - Add ignore-initialization-check annotation to mPendingTextTrackChange from TextTrackList.

https://reviewboard.mozilla.org/r/84888/#review83506

::: dom/media/TextTrackList.h:70
(Diff revision 1)
>  
>    IMPL_EVENT_HANDLER(change)
>    IMPL_EVENT_HANDLER(addtrack)
>    IMPL_EVENT_HANDLER(removetrack)
>  
> -  bool mPendingTextTrackChange;
> +  MOZ_INIT_OUTSIDE_CTOR bool mPendingTextTrackChange;

Isn't the warning telling us that on some constructor paths mPendingTrackChange isn't initialized? How about we just go:

bool mPendingTextTrackChange = false;

here, so it's alway initialized?

Comment 5

[Andi [:andi]]

Comment on attachment 8799342 [details]
Bug 1308868 - Add ignore-initialization-check annotation to members from TriangleTyped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84544/diff/2-3/

Comment 6

[Andi [:andi]]

Attachment: Add ignore-initialization-check annotation to which_ from CalleeDesc

MozReview-Commit-ID: FNTRHFpTx2E

Comment 7

[Andi [:andi]]

Attachment: Add ignore-initialization-check annotation to mWorkerPrivate from ClientNavigateRunnable

MozReview-Commit-ID: 2dLsmPWeqSk

Comment 8

[Andi [:andi]]

Attachment: Add ignore-initialization-check annotation to variables from TelephonyCall and TelephonyCallGroup

MozReview-Commit-ID: GT8oz6sCxaX

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b08765d5eb6
Add ignore-initialization-check annotation to mWorkerPrivate from ClientNavigateRunnable. r=baku

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0be6c3f68a
Add ignore-initialization-check annotation to variables from TelephonyCall and TelephonyCallGroup. r=echen

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b08765d5eb6
https://hg.mozilla.org/mozilla-central/rev/ba0be6c3f68a

Comment 12

[Andi [:andi]]

Attachment: Add ignore-initialization-check annotation to mErrorCode from U2FStatus

MozReview-Commit-ID: 1dIKcbbeStW

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f65cc8c9aace
Add ignore-initialization-check annotation to mErrorCode from U2FStatus. r=baku

Comment 15

[Andi [:andi]]

Attachment: Add ignore-initialization-check annotation to time from RecentURIKey

MozReview-Commit-ID: ZDCY7i19x5

Comment 16

[Andi [:andi]]

Attachment: Add ignore-initialization-check annotation to mPosition and mLine from TextTrackCue

MozReview-Commit-ID: AYPnCUEtMrE

Comment 17

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8802097 [details] [diff] [review]
Add ignore-initialization-check annotation to mPosition and mLine from TextTrackCue

Review of attachment 8802097 [details] [diff] [review]:
-----------------------------------------------------------------

forward review to Ralph.

Comment 18

[Ralph Giles (:rillian)]

Comment on attachment 8802097 [details] [diff] [review]
Add ignore-initialization-check annotation to mPosition and mLine from TextTrackCue

Review of attachment 8802097 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine; the accesses are protected by the `IsAutoKeyword` tags. It would be better to convert these to a Variant type so the compiler checks for us, though.

Comment 19

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f65cc8c9aace

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40a7a506f5bb
Add ignore-initialization-check annotation to time from RecentURIKey. r=adw

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37e81a1c152c
Add ignore-initialization-check annotation to mPosition and mLine from TextTrackCue. r=giles

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/40a7a506f5bb

Comment 23

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/37e81a1c152c

Comment 24

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8799342 [details]
Bug 1308868 - Add ignore-initialization-check annotation to members from TriangleTyped.

https://reviewboard.mozilla.org/r/84544/#review87488

Comment 25

[Julien Cristau [:jcristau] (back April 22)]

Too late for firefox 52, mass-wontfix.

Comment 26

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:andi, maybe it's time to close this bug?

Comment 27

[Andi [:andi]]

Most of the work for this bug has already landed in m-c, an since now we will have coverity during review phase this is no longer necessary, so closing it.