1308886 - about:config's searchbox's placeholder text with very low contrast compared to background

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of issue

Firefox for Android 20161009 on Xperia Z3 Compact with Android 6.0.1

The placeholder text for the searchbox in about:config has a very low contract compared to the background (ligth gray vs. medium gray).

Comment 1

[Ioana Chiorean]

Anthony, is this something we can do here?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Ioana Chiorean from comment #1)
> Anthony, is this something we can do here?

I'm not sure why this is happening, but we could just use our normal 'text grey' here.

CC'ing Sebastian.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Nightly and Aurora seem to be affected.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

HTML:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/config.xhtml

JavaScript:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/config.js

Comment 6

[Julian Chu [:walkingice]]

Attachment: set placeholder color to #777777

I pick color from colors.xml[1], and now it looks like the attachment.

[1] https://dxr.mozilla.org/mozilla-central/rev/79feeed4293336089590320a9f30a813fade8e3c/mobile/android/base/resources/values/colors.xml#18

Comment 7

[Julian Chu [:walkingice]]

Attachment: Bug 1308886 - change color for searchbox's placeholder

the color code is same as R.color.placeholder_grey in
themes/core/config.css

Review commit: https://reviewboard.mozilla.org/r/93652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93652/

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8811588 [details]
Bug 1308886 - change color for searchbox's placeholder

https://reviewboard.mozilla.org/r/93652/#review93714

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8811576 [details]
set placeholder color to #777777

WFM!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01409299e7b5
change color for searchbox's placeholder r=sebastian

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/01409299e7b5

Comment 12

[areya]

https://hg.mozilla.org/mozilla-central/rev/01409299e7b5

Comment 13

[Sebastian Kaspari (:sebastian; :pocmo)]

This affects 51 and 52 too. We could uplift this. about:config is not really supported - however this patch seems to be safe to uplift.

Comment 14

[Julian Chu [:walkingice]]

Comment on attachment 8811588 [details]
Bug 1308886 - change color for searchbox's placeholder

Approval Request Comment
[Feature/regressing bug #]: Change color for placeholder to give better contrast

[User impact if declined]: User cannot see clear placeholder text

[Describe test coverage new/current, TreeHerder]: manually check the color

[Risks and why]: Low. It just changes CSS color

[String/UUID change made/needed]: -

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8811588 [details]
Bug 1308886 - change color for searchbox's placeholder

Fix a UI issue. Beta51+ and Aurora52+. Should be in 51 beta 4.

Comment 16

[Bogdan Surd, QA [:bsurd, NI]]

Hello,

Verified on a Nexus 9 (Android 6.0.1) on the latest Nightly 53.0a1

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be41fbd836e3

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fab9a1ea282d

Comment 19

[Bogdan Surd, QA [:bsurd, NI]]

Verified on a Nexus 9 (Android 7.0) using 51.0b4