Make use of ScopedAutoSECItem in CryptoKey.cpp

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
One of the things ScopedAutoSECItem is useful for is getting rid of this pattern:
> ScopedSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));

While this pattern works, ScopedAutoSECItem is slightly superior in that it doesn't unnecessarily cause a SECItem to be allocated from the heap. Moreover, this moves us further away from Scoped.h, which is deprecated.
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8800041 [details]
Bug 1308890 - Make use of ScopedAutoSECItem in CryptoKey.cpp.

https://reviewboard.mozilla.org/r/85048/#review84218
Attachment #8800041 - Flags: review?(rlb) → review+
Comment hidden (mozreview-request)

Comment 5

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/32425af1283d
Make use of ScopedAutoSECItem in CryptoKey.cpp. r=rbarnes
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/32425af1283d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.