1308890 - Make use of ScopedAutoSECItem in CryptoKey.cpp

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[:Cykesiopka]

One of the things ScopedAutoSECItem is useful for is getting rid of this pattern:
> ScopedSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));

While this pattern works, ScopedAutoSECItem is slightly superior in that it doesn't unnecessarily cause a SECItem to be allocated from the heap. Moreover, this moves us further away from Scoped.h, which is deprecated.

Comment 1

[:Cykesiopka]

Attachment: Bug 1308890 - Make use of ScopedAutoSECItem in CryptoKey.cpp.

ScopedAutoSECItem is useful for is getting rid of this pattern:
> ScopedSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));

While this pattern works, ScopedAutoSECItem is slightly superior in that it
doesn't unnecessarily cause a SECItem to be allocated from the heap. Moreover,
this moves us further away from Scoped.h, which is deprecated.

Review commit: https://reviewboard.mozilla.org/r/85048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85048/

Comment 2

[Richard Barnes [:rbarnes]]

Comment on attachment 8800041 [details]
Bug 1308890 - Make use of ScopedAutoSECItem in CryptoKey.cpp.

https://reviewboard.mozilla.org/r/85048/#review84218

Comment 3

[:Cykesiopka]

Comment on attachment 8800041 [details]
Bug 1308890 - Make use of ScopedAutoSECItem in CryptoKey.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85048/diff/1-2/

Comment 4

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41520f8f1150f06c41857700e931695760cf88ae

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32425af1283d
Make use of ScopedAutoSECItem in CryptoKey.cpp. r=rbarnes

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/32425af1283d