1308924 - Several issues when unplugging the webcam/microphone during a multiple devices call

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Note]:
- This issue in reproducible on sites like https://web.ciscospark.com/, https://opentokrtc.com/, https://apprtc.appspot.com/, https://meet.jit.si/, https://talky.io/, https://appear.in/.

[Affected versions]:
- latest Nightly 52.0a1 (2016-10-09)
- latest Aurora 51.0a2 (2016-10-10)
- 50.0b5 build1 (20161006105459)
- 49.0.1 build3 (20160922113459)

[Affected platforms]:
- Windows XP x86
- Windows 7 x64
- Windows 8.1 x86
- Windows 10 x64

[Steps to reproduce]:
*Prerequisites: have multiple microphones connected to your station (and also enabled) 
1. Launch Firefox
2. Go to https://web.ciscospark.com/, give your device permissions and enter in a call
3. Unplug the microphone 
4. Connect back the microphone 
5. Refresh the browser in order to reestablish the call and give again your device permissions

[Expected result]:
- [step3] Once the microphone is unplugged, the call continues without problems using another connected (enabled) microphone

[Actual result]:
- [step3] The call freezes and no other enabled microphone is used
- [step4] The connection isn't restored 
- [step5] Although the device permissions were given, they are still asked and the connection isn't restored 

[Regression range]:
- I will investigate this as soon as possible

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Paul - thoughts?  Can you repro?

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Paul - is this fixed by landings in other bugs in 52 & 51?

Comment 3

[Paul Adenot (:padenot)]

Yes.

Comment 4

[Paul Adenot (:padenot)]

This does not seem to be a regression. I can repro on all releases. Nightly and Dev Edition are better in the sense that it does not block everything, just your camera.

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

Mass wontfix for bugs affecting firefox 52.

Comment 6

[Paul Adenot (:padenot)]

Can we re-check this, especially on dev edition and nightly, but also on other builds ? I've done some work in the area, and it should be better.

Comment 7

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Paul Adenot (:padenot) from comment #6)
> Can we re-check this, especially on dev edition and nightly, but also on
> other builds ? I've done some work in the area, and it should be better.

Hello, Paul!
Investigated the issue on 54.0a2 (2017-04-07) and 55.0a1 (2017-04-07).  The first and the second actual results are still reproducible (see comment 0), but the third one is resolved (the connection is successfully restored after the refresh).

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

the first and second "actual results" (automatic failover to another mic, and automatic restoration to original mic on re-plug-in) are not currently expected to happen, though on some OSes it might do this "behind the scenes" for some cases (particularly for analog inputs on things like Mac).  So if the third one is resolved, this bug is fixed.

Paul, if you disagree, let's open a new bug on whatever you think we should be doing.  We could also open bugs on what we'd like to have happen in these unplug/replug cases.

Comment 9

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I have to make an update: we still manage to reproduce the first actual result of this issue ([step3] The call freezes and no other enabled microphone is used) on Mac OS X 10.9 (see https://public.etherpad-mozilla.org/p/webrtc-fullduplex-54.0b1). According to the full-duplex audio streams support (bug 1142613), this issue shouldn't be encountered on Mac. Any thoughts about this?

Comment 10

[Alex Chronopoulos [:achronop]]

Can you please provide firefox version info and logs from the error? log flags: MediaStreamGraph:4,cubeb:5

Comment 11

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Alex Chronopoulos [:achronop] from comment #10)
> Can you please provide firefox version info and logs from the error? log
> flags: MediaStreamGraph:4,cubeb:5

Sorry for the delay!
The issue mentioned in comment 9 is still reproducible on Mac OS X 10.9, using 54.0b9 (20170518105722). Here are the recorded logs: https://goo.gl/o4ucwQ.