Closed Bug 1308949 Opened 8 years ago Closed 8 years ago

Keep MYMETA.json up-to-date when checksetup is run

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Version:
5.1.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 6.0

People

(Reporter: dylan, Assigned: dylan)

Details

Attachments

(2 files)

1308949_3.patch
117.74 KB, patch
dkl
: review+
Details | Diff | Splinter Review
1308949_bmo.patch
1.24 KB, patch
dkl
: review+
Details | Diff | Splinter Review 
When Makefile.PL has a newer mtime than MYMETA.json, or MYMETA.json doesn't exist, checksetup.pl should be run.
Assignee: general → dylan
Attached patch 1308949_3.patch — — Splinter Review 
This unconditionally runs Makefile.PL, with hacks to prevent it from showing output. If it produces an unusable MYMETA.json, it removes it so it will fallback to META.json.
Attachment #8799545 - Flags: review?(dkl)
And here is the variant for bmo (same code, just not including the checksetuplib stuff).
Attachment #8799548 - Flags: review?(dkl)
Comment on attachment 8799545 [details] [diff] [review]
1308949_3.patch

Review of attachment 8799545 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8799545 - Flags: review?(dkl) → review+
Comment on attachment 8799548 [details] [diff] [review]
1308949_bmo.patch

Review of attachment 8799548 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8799548 - Flags: review?(dkl) → review+
To github.com:bugzilla/bugzilla.git
   d943c46..d1e7da3  master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
To git@github.com:mozilla-bteam/bmo.git
   0bd2c87..2f310fb  master -> master
Target Milestone: --- → Bugzilla 6.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: