Closed Bug 1308969 Opened 8 years ago Closed 7 years ago

Intermittent /html/browsers/browsing-the-web/history-traversal/browsing_context_name.html | Retaining window.name on history traversal - assert_equals: expected "test1" but got "test"

Categories

(Core :: DOM: Navigation, defect)

52 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: aryx, Assigned: jgraham)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1302621 +++

https://treeherder.mozilla.org/logviewer.html#?job_id=4784294&repo=autoland

07:53:38     INFO - PROCESS | 6427 | 1476111218058	Marionette	TRACE	conn2 -> [0,1912,"executeAsyncScript",{"scriptTimeout":null,"sandbox":"default","debug_script":false,"script":"/* This Source Code Form is subject to the terms of the Mozilla Public\n * License, v. 2.0. If a copy of the MPL was not distributed with this\n * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n\nwindow.wrappedJSObject.timeout_multiplier = 3;\nwindow.wrappedJSObject.explicit_timeout = 0;\n\nwindow.wrappedJSObject.addEventListener(\"message\", function listener(event) {\n    if (event.data.type != \"complete\") {\n        return;\n    }\n    window.wrappedJSObject.removeEventListener(\"message\", listener);\n    clearTimeout(timer);\n    var tests = event.data.tests;\n    var status = event.data.status;\n\n    var subtest_results = tests.map(function(x) {\n        return [x.name, x.status, x.message, x.stack]\n    });\n\n    marionetteScriptFinished([\"/html/browsers/browsing-the-web/history-traversal/PopStateEvent.html\",\n                              status.status,\n                              status.message,\n                              status.stack,\n                              subtest_results]);\n}, false);\n\nwindow.wrappedJSObject.win = window.open(\"http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/PopStateEvent.html\", \"c8bf8a61-578f-4f34-a9b0-267712c8f5e3\");\n\nvar timer = null;\nif (30000) {\n    timer = setTimeout(function() {\n        log(\"Timeout fired\");\n        window.wrappedJSObject.win.timeout();\n    }, 30000);\n}\n","newSandbox":false,"line":410,"args":[],"filename":"executormarionette.py"}]
07:53:38     INFO - PROCESS | 6427 | ++DOCSHELL 0x127d54800 == 5 [pid = 6430] [id = 480]
07:53:38     INFO - PROCESS | 6427 | ++DOMWINDOW == 95 (0x127bb5c00) [pid = 6430] [serial = 1439] [outer = 0x0]
07:53:38     INFO - PROCESS | 6427 | ++DOMWINDOW == 96 (0x127d28c00) [pid = 6430] [serial = 1440] [outer = 0x127bb5c00]
07:53:38     INFO - PROCESS | 6427 | ++DOMWINDOW == 97 (0x127d30800) [pid = 6430] [serial = 1441] [outer = 0x127bb5c00]
07:53:38     INFO - PROCESS | 6427 | 1476111218445	Marionette	TRACE	conn2 <- [1,1912,null,{"value":["/html/browsers/browsing-the-web/history-traversal/PopStateEvent.html",0,null,null,[["document.createEvent",0,null,null],["initPopStateEvent",0,null,null],["Dispatching a synthetic PopStateEvent",0,null,null]]]}]
07:53:38     INFO - ...
07:53:38     INFO - TEST-OK | /html/browsers/browsing-the-web/history-traversal/PopStateEvent.html | took 587ms
07:53:38     INFO - TEST-START | /html/browsers/browsing-the-web/history-traversal/browsing_context_name.html
07:53:38     INFO - PROCESS | 6427 | 1476111218481	Marionette	TRACE	conn2 -> [0,1913,"getWindowHandle",null]
07:53:38     INFO - PROCESS | 6427 | 1476111218482	Marionette	TRACE	conn2 <- [1,1913,null,{"value":"2147483649"}]
07:53:38     INFO - PROCESS | 6427 | 1476111218485	Marionette	TRACE	conn2 -> [0,1914,"timeouts",{"script":35000}]
07:53:38     INFO - PROCESS | 6427 | 1476111218489	Marionette	TRACE	conn2 <- [1,1914,null,{}]
07:53:38     INFO - PROCESS | 6427 | 1476111218501	Marionette	TRACE	conn2 -> [0,1915,"executeScript",{"scriptTimeout":null,"newSandbox":true,"args":[],"filename":"executormarionette.py","script":"if (window.wrappedJSObject.win) {window.wrappedJSObject.win.close()}","sandbox":"default","line":396}]
07:53:38     INFO - PROCESS | 6427 | 1476111218565	Marionette	TRACE	conn2 <- [1,1915,null,{"value":null}]
07:53:38     INFO - PROCESS | 6427 | 1476111218574	Marionette	TRACE	conn2 -> [0,1916,"executeAsyncScript",{"scriptTimeout":null,"sandbox":"default","debug_script":false,"script":"/* This Source Code Form is subject to the terms of the Mozilla Public\n * License, v. 2.0. If a copy of the MPL was not distributed with this\n * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n\nwindow.wrappedJSObject.timeout_multiplier = 3;\nwindow.wrappedJSObject.explicit_timeout = 0;\n\nwindow.wrappedJSObject.addEventListener(\"message\", function listener(event) {\n    if (event.data.type != \"complete\") {\n        return;\n    }\n    window.wrappedJSObject.removeEventListener(\"message\", listener);\n    clearTimeout(timer);\n    var tests = event.data.tests;\n    var status = event.data.status;\n\n    var subtest_results = tests.map(function(x) {\n        return [x.name, x.status, x.message, x.stack]\n    });\n\n    marionetteScriptFinished([\"/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html\",\n                              status.status,\n                              status.message,\n                              status.stack,\n                              subtest_results]);\n}, false);\n\nwindow.wrappedJSObject.win = window.open(\"http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html\", \"c8bf8a61-578f-4f34-a9b0-267712c8f5e3\");\n\nvar timer = null;\nif (30000) {\n    timer = setTimeout(function() {\n        log(\"Timeout fired\");\n        window.wrappedJSObject.win.timeout();\n    }, 30000);\n}\n","newSandbox":false,"line":410,"args":[],"filename":"executormarionette.py"}]
...
07:53:39     INFO - PROCESS | 6427 | 1476111219808	Marionette	TRACE	conn2 <- [1,1916,null,{"value":["/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html",0,null,null,[["Retaining window.name on history traversal",1,"assert_equals: expected \"test1\" but got \"test\"","steps<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:26:16\nsteps</<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:34:72\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20\nnext<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:37:32\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20\nsetTimeout handler*steps<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:24:55\nsteps</<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:34:72\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20\nnext<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:37:32\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20\nsetTimeout handler*steps<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:22:17\nsteps</<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:34:72\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20\nnext<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:37:32\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20\nEventHandlerNonNull*@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:39:1\n"]]]}]
07:53:39     INFO - 
07:53:39     INFO - TEST-UNEXPECTED-FAIL | /html/browsers/browsing-the-web/history-traversal/browsing_context_name.html | Retaining window.name on history traversal - assert_equals: expected "test1" but got "test"
07:53:39     INFO - steps<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:26:16
07:53:39     INFO - steps</<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:34:72
07:53:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20
07:53:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20
07:53:39     INFO - next<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:37:32
07:53:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20
07:53:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20
07:53:39     INFO - setTimeout handler*steps<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:24:55
07:53:39     INFO - steps</<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:34:72
07:53:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20
07:53:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20
07:53:39     INFO - next<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:37:32
07:53:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20
07:53:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20
07:53:39     INFO - setTimeout handler*steps<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:22:17
07:53:39     INFO - steps</<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:34:72
07:53:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20
07:53:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20
07:53:39     INFO - next<@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:37:32
07:53:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20
07:53:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1427:20
07:53:39     INFO - EventHandlerNonNull*@http://web-platform.test:8000/html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:39:1
07:53:39     INFO - TEST-OK | /html/browsers/browsing-the-web/history-traversal/browsing_context_name.html | took 1334ms
Component: web-platform-tests → Document Navigation
Product: Testing → Core
Version: Version 3 → 52 Branch
See Also: → 1302621
Comment on attachment 8838428 [details]
Bug 1308969 - Fix cross-origin browser name test,

https://reviewboard.mozilla.org/r/113372/#review114836

::: testing/web-platform/tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin-0.html:3
(Diff revision 1)
> +<iframe id="test"></iframe>
> +<script>
> +var opener = window.opener;

No need for this, I think.

::: testing/web-platform/tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin-0.html:8
(Diff revision 1)
> +var opener = window.opener;
> +var t = opener.t;
> +var f = document.getElementById("test");
> +var l = opener.document.getElementById("step_log");
> +
> +log = function(t) {l.textContent += ("\n" + t)}

`var`

::: testing/web-platform/tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin.html:10
(Diff revision 1)
> -].map(function(x) {return t.step_func(function() {log("Step " + step); x()})});
>  
> -var step = 0;
> -next = t.step_func(function() {steps[step++]()});
> -
> -f.onload=next;
> +<script>
> +var t = async_test();
> +t.step(() => {
> +  win = window.open("browsing_context_name_cross_origin-0.html");

`var`
Attachment #8838428 - Flags: review?(Ms2ger) → review+
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65467acedb74
Fix cross-origin browser name test, r=Ms2ger
backed out in sorry had to back out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=fb36e9f08e715f03238964eeb641078681e14862 for the timeout in the push because it depended on this code changes here
Flags: needinfo?(james)
Pushed by Ms2ger@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67538b51b43a
Fix cross-origin browser name test, r=Ms2ger
https://hg.mozilla.org/integration/mozilla-inbound/rev/72bc1a760ddd
Disable EventListener-invoke-legacy.html
https://hg.mozilla.org/mozilla-central/rev/67538b51b43a
https://hg.mozilla.org/mozilla-central/rev/72bc1a760ddd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Assignee: nobody → james
Flags: needinfo?(james)
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/1037177b3853
Backed out changeset 72bc1a760ddd for Win7 opt and pgo W(1) perma failures in idbdatabase_deleteObjectStore.htm. a=backout
https://hg.mozilla.org/mozilla-central/rev/0e19b703e0df
Backed out changeset 67538b51b43a
hey ryan, you set firefox53 and 52 to fixed, but there is no uplift ?
Flags: needinfo?(ryanvm)
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4af59675bb8
Fix cross-origin browser name test, r=Ms2ger
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8403cbd2ee4
Disable EventListener-invoke-legacy.html
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: needinfo?(james)
Resolution: --- → FIXED
(In reply to Carsten Book [:Tomcat] from comment #21)
> hey ryan, you set firefox53 and 52 to fixed, but there is no uplift ?

Because OF says this went away when bug 1302621 landed.
Flags: needinfo?(ryanvm)
I've narrowed down that this change causes a regression in the Wd job. All tests error out, but the job remains green. I can reproduce locally. Roughly, it looks like the tests start running before the browser starts up. 

Ref: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c8403cbd2ee4af3afaea003658d95457f7cce841&filter-searchStr=wd

Excerpt:
17-02-20T12:56:30.467110Z] 12:56:30     INFO - STDOUT: collected 22 items
[task 2017-02-20T12:56:30.468720Z] 12:56:30     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_no_actions_send_no_events 
[task 2017-02-20T12:56:30.977466Z] 12:56:30     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:31.028449Z] 12:56:31     INFO - PROCESS | 880 | 1487595391025	Marionette	INFO	Listening on port 2828
[task 2017-02-20T12:56:31.244977Z] 12:56:31     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_no_actions_send_no_events 
[task 2017-02-20T12:56:31.245292Z] 12:56:31     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:31.249872Z] 12:56:31     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_lone_keyup_sends_no_events 
[task 2017-02-20T12:56:31.443539Z] 12:56:31     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:31.729091Z] 12:56:31     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_lone_keyup_sends_no_events 
[task 2017-02-20T12:56:31.729400Z] 12:56:31     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:31.734135Z] 12:56:31     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_single_printable_key_sends_correct_events[0a-KeyA] 
[task 2017-02-20T12:56:31.999550Z] 12:56:31     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:32.429982Z] 12:56:32     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_single_printable_key_sends_correct_events[0a-KeyA] 
[task 2017-02-20T12:56:32.432449Z] 12:56:32     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:32.436726Z] 12:56:32     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_single_printable_key_sends_correct_events[1a-KeyA] 
[task 2017-02-20T12:56:32.738168Z] 12:56:32     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:33.040743Z] 12:56:33     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_single_printable_key_sends_correct_events[1a-KeyA] 
[task 2017-02-20T12:56:33.042256Z] 12:56:33     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:33.044328Z] 12:56:33     INFO - STDOUT: tests/web-platform/tests/webdriver/actions.py::test_single_printable_key_sends_correct_events[2"-Quote] 
[task 2017-02-20T12:56:33.310809Z] 12:56:33     INFO - STDOUT: ERROR
[task 2017-02-20T12:56:33.460761Z] 12:56:33     INFO - STDOUT: tests/
Flags: needinfo?(james)
The Wd spec tests will be fixed when we release geckodriver and do a wpt sync
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.