If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add an additional test with an hybrid SDK addon which uses the new module loader

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
WebExtensions: General
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: rpl, Assigned: rpl)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Currently the test addon related to the hybrid SDK addons (the one that can be found at "addon-sdk/source/test/addons/embedded-webextension") is build as part of jetpack test suite using the old cfx tool.

Unfortunately, addons built with cfx are going to use the old (and deprecated) module loader instead of the new one (the one that any real addon is going to use), and so, to reduce the chances that the "embedded webextension" support included in the currently used SDK module loader could become broken without being noticed as a tests failure, it would be good to include an additional hybrid SDK test addon that uses the new module loader instead.
(Assignee)

Updated

a year ago
Blocks: 1252227
Whiteboard: triaged
(Assignee)

Updated

a year ago
Assignee: nobody → lgreco
Iteration: --- → 52.2 - Oct 17
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
Attachment #8799496 [details] push to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc2b53842865548eeb4a3b02eaac2fd0a3f22639
Comment on attachment 8799496 [details]
Bug 1309003 - [webext] Test an hybrid SDK addon which uses the current SDK module loader.

https://reviewboard.mozilla.org/r/84656/#review83262
Attachment #8799496 - Flags: review?(kmaglione+bmo) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 4

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50d7b9b0b423
[webext] Test an hybrid SDK addon which uses the current SDK module loader. r=kmag
Keywords: checkin-needed
Backed out for timing out test_chrome_ext_hybrid_addons.html on Android:

https://hg.mozilla.org/integration/autoland/rev/589eaa68f004ba4c0bca94ba4cc4a41446ccc78e

Push with failures: https://hg.mozilla.org/integration/autoland/rev/589eaa68f004ba4c0bca94ba4cc4a41446ccc78e
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=4858087&repo=autoland

[task 2016-10-11T15:55:32.752816Z] 15:55:32     INFO -  155 INFO TEST-START | toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html
[task 2016-10-11T16:00:55.271774Z] 16:00:55     INFO -  156 INFO Error: Unable to restore focus, expect failures and timeouts.
[task 2016-10-11T16:00:55.271890Z] 16:00:55     INFO -  157 INFO Error: Unable to restore focus, expect failures and timeouts.
[task 2016-10-11T16:00:55.271965Z] 16:00:55     INFO -  158 INFO SpawnTask.js | Entering test test_sdk_hybrid_addon_with_jpm_module_loader
[task 2016-10-11T16:00:55.272003Z] 16:00:55     INFO -  159 INFO Extension loaded
[task 2016-10-11T16:00:55.272094Z] 16:00:55     INFO -  160 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html | Test timed out.
[task 2016-10-11T16:00:55.273429Z] 16:00:55     INFO -  reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:114:7
[task 2016-10-11T16:00:55.273998Z] 16:00:55     INFO -  TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:135:7
Flags: needinfo?(lgreco)
Comment hidden (mozreview-request)
(Assignee)

Comment 7

a year ago
The reason of the timeout failure on Android was related to "Firefox for Android" (or fennec) being missing from the supported target applications in the install.rdf of the test addons that this tests contains, but besides that this test should be able to run on Fennec as well (and I tried the fixed version of this mochitest-chrome on a local android emulator and it passes without issues). 

I've just pushed the updated version of the patch on mozreview, and I pushed it to try as well (with android-api-15 as the target platform, to be sure that this test now works correctly on the build infrastructure, as it does locally on the android emulator):

- https://treeherder.mozilla.org/#/jobs?repo=try&revision=c860f56a2cfd79f786627e895dba0ee292723a00
Flags: needinfo?(lgreco)
(Assignee)

Updated

11 months ago
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 8

11 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57667da3806c
[webext] Test an hybrid SDK addon which uses the current SDK module loader. r=kmag
Keywords: checkin-needed

Comment 9

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/57667da3806c
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.