1309019 - |hg push -r 1234 review| does not limit to just revision 1234

Status: RESOLVED INVALID

(MozReview Graveyard :: Integration: Mercurial, defect)

Description

[Eric Rahm [:erahm]]

> [erahm@mozilla21268 mozilla-central]$ hg push -r 316929 review
> pushing to ssh://reviewboard-hg.mozilla.org/autoreview
> searching for appropriate review repository
> redirecting push to ssh://reviewboard-hg.mozilla.org/gecko
> searching for changes
> remote: adding changesets
> remote: adding manifests
> remote: adding file changes
> remote: added 3 changesets with 3 changes to 11 files (+1 heads)
> remote: recorded push in pushlog
> abort: cannot submit reviews referencing multiple bugs
> (limit reviewed changesets with "-c" or "-r" arguments)

Looking at other bug reports it seems like maybe only |-c| is supported? If so we should update the docs and not tell people to use -r.

Comment 1

[Mark Côté [:mcote]]

We have a note to that effect in the documentation, in this section: http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#choosing-which-commits-to-submit

Perhaps it's not obvious enough though.  Any suggestions for improving it?  Maybe moving the paragraph on "-c" up somewhere?

Comment 2

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.