130904 - Leaks in nsHTMLCSSUtils::GetDefaultViewCSS()

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

We have leaks in nsHTMLCSSUtils::GetDefaultViewCSS() and should use nsCOMPtr's
there to easily solve the problem. My fault, even if I copied a large portion
of this code from another place in the source, that was fixed by someone else
in the meantime.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.0

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 74082 [details] [diff] [review]
patch v1.0

r=peterv.

Comment 3

[kinmoz]

Comment on attachment 74082 [details] [diff] [review]
patch v1.0

sr=[e-mail]

-      abstractView->QueryInterface(NS_GET_IID(nsIDOMViewCSS),
-			   (void **) aViewCSS);
+      CallQueryInterface(abstractView, aViewCSS);
       return NS_OK;


Do we want to do a "return CallQueryInterface( ... )" , just in case the QI
fails? or does the caller check aViewCSS for NULL?

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

peterv had same question ; the caller always checks for null.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 74082 [details] [diff] [review]
patch v1.0

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

checked in (trunk)

Comment 7

[sujay]

Daniel, please verify...thanks.

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

verified