1309040 - Remove preference testing from test_css-properties.js

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P2)

Description

[Greg Tatum [:gregtatum]]

The CSS properties database originally tried to capture information about how the compile time flags and preferences worked together to determine if a css property was valid or not on a given platform. The compile time flags ended up making this difficult to do, so the test enforcing the database was changed to be nightly only. Because of this, now it makes sense to strip out the preferences from the database, as it is just noise that doesn't contribute anything.

The CSS database will represent the default properties on nightly gecko as given by the combination of preferences and compile time flags.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1309040 - Update mach devtools-css-db to be more accurate in generating the db;

This patch removes the preferences from the css properties db as they
are not needed anymore. It also makes the generation process more
robust when the properties-db.js has been deleted. Finally the comments
have been updated to reflect the recent change in approach to the
devtools-css-db.

Review commit: https://reviewboard.mozilla.org/r/84962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84962/

Comment 2

[Tom Tromey :tromey]

Comment on attachment 8799897 [details]
Bug 1309040 - Update mach devtools-css-db to be more accurate in generating the db;

https://reviewboard.mozilla.org/r/84962/#review83524

Thank you.  This looks good.  I opened a couple of minor issues, but nothing too serious.

::: devtools/shared/css/generated/mach_commands.py:16
(Diff revision 1)
>  import json
>  import os
>  import sys
>  import string
>  import subprocess
>  from mozbuild import shellutil

I think the shellutil import isn't needed any more.

::: devtools/shared/css/generated/mach_commands.py:89
(Diff revision 1)
>              js_template = handle.read()
>  
>          preamble = '/* THIS IS AN AUTOGENERATED FILE.  DO NOT EDIT */\n\n'
>          contents = string.Template(js_template).substitute(substitutions)
>  
> -        with open(destination_path, 'wb') as destination:
> +        with open(destination_path, 'wb+') as destination:

I don't understand the need for this change.

Comment 3

[Greg Tatum [:gregtatum]]

Comment on attachment 8799897 [details]
Bug 1309040 - Update mach devtools-css-db to be more accurate in generating the db;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84962/diff/1-2/

Comment 4

[Greg Tatum [:gregtatum]]

Comment on attachment 8799897 [details]
Bug 1309040 - Update mach devtools-css-db to be more accurate in generating the db;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84962/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f21dc1f1f2aa
Update mach devtools-css-db to be more accurate in generating the db; r=tromey

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f21dc1f1f2aa