Closed Bug 1309040 Opened 3 years ago Closed 3 years ago

Remove preference testing from test_css-properties.js

Categories

(DevTools :: Framework, defect, P2)

defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

Details

Attachments

(1 file)

The CSS properties database originally tried to capture information about how the compile time flags and preferences worked together to determine if a css property was valid or not on a given platform. The compile time flags ended up making this difficult to do, so the test enforcing the database was changed to be nightly only. Because of this, now it makes sense to strip out the preferences from the database, as it is just noise that doesn't contribute anything.

The CSS database will represent the default properties on nightly gecko as given by the combination of preferences and compile time flags.
Assignee: nobody → gtatum
Comment on attachment 8799897 [details]
Bug 1309040 - Update mach devtools-css-db to be more accurate in generating the db;

https://reviewboard.mozilla.org/r/84962/#review83524

Thank you.  This looks good.  I opened a couple of minor issues, but nothing too serious.

::: devtools/shared/css/generated/mach_commands.py:16
(Diff revision 1)
>  import json
>  import os
>  import sys
>  import string
>  import subprocess
>  from mozbuild import shellutil

I think the shellutil import isn't needed any more.

::: devtools/shared/css/generated/mach_commands.py:89
(Diff revision 1)
>              js_template = handle.read()
>  
>          preamble = '/* THIS IS AN AUTOGENERATED FILE.  DO NOT EDIT */\n\n'
>          contents = string.Template(js_template).substitute(substitutions)
>  
> -        with open(destination_path, 'wb') as destination:
> +        with open(destination_path, 'wb+') as destination:

I don't understand the need for this change.
Attachment #8799897 - Flags: review?(ttromey) → review+
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f21dc1f1f2aa
Update mach devtools-css-db to be more accurate in generating the db; r=tromey
https://hg.mozilla.org/mozilla-central/rev/f21dc1f1f2aa
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.