Closed Bug 1309062 Opened 5 years ago Closed 5 years ago

Documentation lists wrong contract id for address book directory factories

Categories

(Thunderbird :: Address Book, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: public, Unassigned)

Details

In nsIAbDirFactoryService.idl (<https://dxr.mozilla.org/comm-central/source/mailnews/addrbook/public/nsIAbDirFactoryService.idl>), it is documented that implementations shall have the contract
> @mozilla.org/addressbook/directory-factory;1?type=<scheme>
but correct would be
> @mozilla.org/addressbook/directory-factory;1?name=<scheme>
(see NS_AB_DIRECTORY_FACTORY_CONTRACTID_PREFIX, <https://dxr.mozilla.org/comm-central/source/mailnews/addrbook/public/nsAbBaseCID.h#16>)
Pushed http://hg.mozilla.org/comm-central/rev/9780f198b3bb

(we agreed a few months ago that peers can fix documentation issues without review)

I also confirmed this by checking that name= is what I actually use in ExQuilla, as OP suggests.
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
(In reply to Kent James (:rkent) from comment #1)
> (we agreed a few months ago that peers can fix documentation issues without
> review)
Right. And to land the patch with DONTBUILD ;-)
You need to log in before you can comment on or make changes to this bug.