1309080 - First tab thumbnail in tabs panel resizes too small

Status: RESOLVED DUPLICATE of bug 1116415

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Tom Klein]

Attachment: Logcat

STR:
1. Force stop fennec with two tabs open (any number > 1 probably works).
2. Restart fennec.
3. Change the URL of the first tab and then return to the tabs panel.  The thumbnail reloads at a too small size.
4. Load the first tab and then return to the tabs panel again.  The thumbnail is the correct size.
5. Close the first tab and then undo the close.  The thumbnail at first loads at the correct size but then changes to the too small size again.

I can only reproduce the issue with the first tab, the second tab seems fine.

Video of the Step 5 error:
https://youtu.be/OgiwBgmWojU

The attached logcat has some

W/View: requestLayout() improperly called by org.mozilla.gecko.tabs.TabsPanelThumbnailView{638ce14 V.ED..... ......ID 10,10-430,360 #7f0f0197 app:id/thumbnail} during layout: running second layout pass

lines that look suspicious, though they're called after the close, not the undo.

Comment 1

[Tom Klein]

Now that I've played around a little more it seems like the error in step 3 is intermittent, but I'm always seeing the error in step 5 (if there's no error in step 3, you can skip step 4 and still see the error in step 5).  I'm also pretty sure I hadn't done a force close the first time I saw this, that's just a reliable way of reproducing it.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Will this be fixed by the changes in bug 1116415 (Switching to RecyclerView) or is this still an issue after that?

Comment 3

[Tom Klein]

(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> Will this be fixed by the changes in bug 1116415 (Switching to RecyclerView)
> or is this still an issue after that?

Looks like it will be fixed after bug 1116415.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Okay, thanks! I'll close this as a duplicate then. Seems like we are getting closer to landing bug bug 1116415. :)