initialize layer as part of Gecko_EnsureImageLayersLength

RESOLVED FIXED in Firefox 52

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

a year ago
Currently stylo will call Initialize() on an image layer just before writing the computed background-image value into it, but this is the wrong time to do this, since we might already have written the computed background-repeat or background-origin value into the Gecko struct.  So we should instead call Initialize() on any new layers that get appended due to Gecko_EnsureImageLayersLength() calls.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8799600 - Flags: review?(manishearth)
Attachment #8799601 - Flags: review?(manishearth)
(Assignee)

Updated

a year ago
Assignee: nobody → cam
Status: NEW → ASSIGNED

Comment 4

a year ago
mozreview-review
Comment on attachment 8799599 [details]
Bug 1309081 - Initialize image layer as part of Gecko_EnsureImageLayersLength.

https://reviewboard.mozilla.org/r/84734/#review83320
Attachment #8799599 - Flags: review?(manishearth) → review+

Comment 5

a year ago
mozreview-review
Comment on attachment 8799600 [details]
Regenerate bindings.

https://reviewboard.mozilla.org/r/84736/#review83322
Attachment #8799600 - Flags: review?(manishearth) → review+

Comment 6

a year ago
mozreview-review
Comment on attachment 8799601 [details]
Avoid initializing image layers after repeat/origin values have been written.

https://reviewboard.mozilla.org/r/84738/#review83324
Attachment #8799601 - Flags: review?(manishearth) → review+

Comment 8

a year ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61da7056917a
Initialize image layer as part of Gecko_EnsureImageLayersLength. r=manishearth

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/61da7056917a
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.