Closed Bug 1309081 Opened 3 years ago Closed 3 years ago

initialize layer as part of Gecko_EnsureImageLayersLength

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(3 files)

Currently stylo will call Initialize() on an image layer just before writing the computed background-image value into it, but this is the wrong time to do this, since we might already have written the computed background-repeat or background-origin value into the Gecko struct.  So we should instead call Initialize() on any new layers that get appended due to Gecko_EnsureImageLayersLength() calls.
Attachment #8799600 - Flags: review?(manishearth)
Attachment #8799601 - Flags: review?(manishearth)
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment on attachment 8799599 [details]
Bug 1309081 - Initialize image layer as part of Gecko_EnsureImageLayersLength.

https://reviewboard.mozilla.org/r/84734/#review83320
Attachment #8799599 - Flags: review?(manishearth) → review+
Comment on attachment 8799600 [details]
Regenerate bindings.

https://reviewboard.mozilla.org/r/84736/#review83322
Attachment #8799600 - Flags: review?(manishearth) → review+
Comment on attachment 8799601 [details]
Avoid initializing image layers after repeat/origin values have been written.

https://reviewboard.mozilla.org/r/84738/#review83324
Attachment #8799601 - Flags: review?(manishearth) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61da7056917a
Initialize image layer as part of Gecko_EnsureImageLayersLength. r=manishearth
https://hg.mozilla.org/mozilla-central/rev/61da7056917a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.