1309116 - Make StateObject::SetState a variadic template

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

This will allow us to remove InitiateSeek() and always call SetState() to change states. The function will also handle state transition details like entry/exit actions.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1309116. Part 1 - move some functions out of class definition because we need to see the complete definition when trying to 'new' an object.

Review commit: https://reviewboard.mozilla.org/r/85762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85762/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1309116. Part 2 - rewrite StateObject::SetState using variadic template.

Review commit: https://reviewboard.mozilla.org/r/85764/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85764/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1309116. Part 3 - replace InitiateSeek() with StateObject::SetState().

Review commit: https://reviewboard.mozilla.org/r/85766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85766/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1309116. Part 4 - fix remaining calls to MDSM::SetState() and remove unused functions.

Review commit: https://reviewboard.mozilla.org/r/85768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85768/

Comment 5

[Tzuhao Kuo [:kaku]]

Comment on attachment 8800967 [details]
Bug 1309116. Part 1 - move some functions out of class definition because we need to see the complete definition when trying to 'new' an object.

https://reviewboard.mozilla.org/r/85762/#review84432

Comment 6

[Tzuhao Kuo [:kaku]]

Comment on attachment 8800968 [details]
Bug 1309116. Part 2 - rewrite StateObject::SetState using variadic template.

https://reviewboard.mozilla.org/r/85764/#review84434

Comment 7

[Tzuhao Kuo [:kaku]]

Comment on attachment 8800969 [details]
Bug 1309116. Part 3 - replace InitiateSeek() with StateObject::SetState().

https://reviewboard.mozilla.org/r/85766/#review84436

Comment 8

[Tzuhao Kuo [:kaku]]

Comment on attachment 8800970 [details]
Bug 1309116. Part 4 - fix remaining calls to MDSM::SetState() and remove unused functions.

https://reviewboard.mozilla.org/r/85768/#review84438

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Tzuhao Kuo [:kaku] from comment #8)
> Comment on attachment 8800970 [details]
> Bug 1309116. Part 4 - fix remaining calls to MDSM::SetState() and remove
> unused functions.
> 
> https://reviewboard.mozilla.org/r/85768/#review84438

Can you give some review comments for r-?

Comment 10

[Tzuhao Kuo [:kaku]]

(In reply to JW Wang [:jwwang] [:jw_wang] from comment #9)
> (In reply to Tzuhao Kuo [:kaku] from comment #8)
> > Comment on attachment 8800970 [details]
> > Bug 1309116. Part 4 - fix remaining calls to MDSM::SetState() and remove
> > unused functions.
> > 
> > https://reviewboard.mozilla.org/r/85768/#review84438
> 
> Can you give some review comments for r-?

It is a mistake..., sorry.

Comment 11

[Tzuhao Kuo [:kaku]]

Comment on attachment 8800970 [details]
Bug 1309116. Part 4 - fix remaining calls to MDSM::SetState() and remove unused functions.

https://reviewboard.mozilla.org/r/85768/#review84440

Comment 12

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c37bc5153f4
Part 1 - move some functions out of class definition because we need to see the complete definition when trying to 'new' an object. r=kaku
https://hg.mozilla.org/integration/autoland/rev/ac4ed7547bf1
Part 2 - rewrite StateObject::SetState using variadic template. r=kaku
https://hg.mozilla.org/integration/autoland/rev/8f29186034ce
Part 3 - replace InitiateSeek() with StateObject::SetState(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/4d61631a9387
Part 4 - fix remaining calls to MDSM::SetState() and remove unused functions. r=kaku

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5c37bc5153f4
https://hg.mozilla.org/mozilla-central/rev/ac4ed7547bf1
https://hg.mozilla.org/mozilla-central/rev/8f29186034ce
https://hg.mozilla.org/mozilla-central/rev/4d61631a9387