1309129 - Redirect nICEr logging to NSPR

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Nils Ohlmeier [:drno]]

It is really annoying that nICEr logging goes to a different place then most of other logging.

Additionally users on the official Windows release build can't get us any logging above log level Info, because the stdout/stderr are not available on these builds and therefore the nICEr logging goes to /dev/null.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1309129: enable redirecting of nICEr logging to NSPR logging.

Review commit: https://reviewboard.mozilla.org/r/84776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84776/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8799632 [details]
Bug 1309129: enable redirecting of nICEr logging to NSPR logging.

https://reviewboard.mozilla.org/r/84776/#review83480

Hmm. Grafting this extra duty onto this class is a little odd to me. But to separate it out would be a lot more code. Maybe rename the class to something more accurate?

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8799632 [details]
Bug 1309129: enable redirecting of nICEr logging to NSPR logging.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84776/diff/1-2/

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8799632 [details]
Bug 1309129: enable redirecting of nICEr logging to NSPR logging.

https://reviewboard.mozilla.org/r/84776/#review83480

I started with an extra class, tried to add extra code to handle two extra callbacks in nrappkit. And then it dawned on me that I could just extend the existing callback.
Renamed everything to rlogconnector. Not a beauty either, but hopefully less confusing. Let me know if someone has a better proposal.

Comment 5

[Byron Campen [:bwc]]

Comment on attachment 8799632 [details]
Bug 1309129: enable redirecting of nICEr logging to NSPR logging.

https://reviewboard.mozilla.org/r/84776/#review83480

I can live with that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28cab19aa7f1
enable redirecting of nICEr logging to NSPR logging. r=bwc

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28cab19aa7f1