Closed Bug 1309129 Opened 3 years ago Closed 3 years ago

Redirect nICEr logging to NSPR

Categories

(Core :: WebRTC: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed
Blocking Flags:

People

(Reporter: drno, Assigned: drno)

References

Details

Attachments

(1 file)

It is really annoying that nICEr logging goes to a different place then most of other logging.

Additionally users on the official Windows release build can't get us any logging above log level Info, because the stdout/stderr are not available on these builds and therefore the nICEr logging goes to /dev/null.
backlog: --- → webrtc/webaudio+
Rank: 20
See Also: → 1186595
Comment on attachment 8799632 [details]
Bug 1309129: enable redirecting of nICEr logging to NSPR logging.

https://reviewboard.mozilla.org/r/84776/#review83480

Hmm. Grafting this extra duty onto this class is a little odd to me. But to separate it out would be a lot more code. Maybe rename the class to something more accurate?
Attachment #8799632 - Flags: review?(docfaraday) → review+
Comment on attachment 8799632 [details]
Bug 1309129: enable redirecting of nICEr logging to NSPR logging.

https://reviewboard.mozilla.org/r/84776/#review83480

I started with an extra class, tried to add extra code to handle two extra callbacks in nrappkit. And then it dawned on me that I could just extend the existing callback.
Renamed everything to rlogconnector. Not a beauty either, but hopefully less confusing. Let me know if someone has a better proposal.
Comment on attachment 8799632 [details]
Bug 1309129: enable redirecting of nICEr logging to NSPR logging.

https://reviewboard.mozilla.org/r/84776/#review83480

I can live with that.
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/28cab19aa7f1
enable redirecting of nICEr logging to NSPR logging. r=bwc
https://hg.mozilla.org/mozilla-central/rev/28cab19aa7f1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.