Closed Bug 1309140 Opened 3 years ago Closed 3 years ago

Rename CustomElementsRegistry to CustomElementRegistry

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jdai, Assigned: jdai)

References

()

Details

(Whiteboard: dom-ce-m1)

Attachments

(1 file, 1 obsolete file)

According to spec disscussion [1], we need to rename CustomElementsRegistry to CustomElementRegistry.

[1] https://github.com/whatwg/html/pull/1705
Comment on attachment 8800163 [details] [diff] [review]
Bug 1309140 - Rename CustomElementsRegistry to CustomElementRegistry.

Review of attachment 8800163 [details] [diff] [review]:
-----------------------------------------------------------------

You will have to revise https://dxr.mozilla.org/mozilla-central/rev/7ae377917236b7e6111146aa9fb4c073c0efc7f4/dom/tests/mochitest/general/test_interfaces.html#272 as well.

::: dom/base/CustomElementRegistry.cpp
@@ +253,1 @@
>                                                        const nsAString* aIs) const

nit: align arguments.

@@ +293,1 @@
>                                             const nsAString* aTypeExtension)

and here.

@@ +330,1 @@
>                                                   Element* aCustomElement,

Ditto.

@@ +454,1 @@
>                                             JS::MutableHandle<JSObject*> aPrototype)

Ditto.

@@ +466,1 @@
>                                            nsIAtom* aKey,

Ditto.

@@ +562,1 @@
>                                 Function& aFunctionConstructor,

Ditto.

@@ +803,1 @@
>                              JS::MutableHandle<JS::Value> aRetVal)

Ditto.

::: dom/base/CustomElementRegistry.h
@@ +133,1 @@
>                                       public nsWrapperCache

Ditto.
Attachment #8800163 - Flags: feedback?(echen) → feedback+
Addressed comment #2. This patch also require DOM peer review since I modified a CustomElementRegistry WebIDL file.

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2fe7e271d5afe172085607f8c16d2abb9caf293a&filter-tier=1
Attachment #8800163 - Attachment is obsolete: true
Attachment #8800581 - Flags: review?(wchen)
Attachment #8800581 - Flags: review?(bugs)
Comment on attachment 8800581 [details] [diff] [review]
Bug 1309140 - Rename CustomElementsRegistry to CustomElementRegistry. v2

r+ for the .webidl
Attachment #8800581 - Flags: review?(bugs) → review+
Attachment #8800581 - Flags: review?(wchen) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e45980db4f43
Rename CustomElementsRegistry to CustomElementRegistry. r=wchen, r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e45980db4f43
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Whiteboard: dom-ce-m1
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.