Closed Bug 1309142 Opened 4 years ago Closed 4 years ago

Move some code to ShutdownState

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → jwwang
Blocks: 1295892
Priority: -- → P3
Attachment #8801017 - Flags: review?(jacheng)
Attachment #8801018 - Flags: review?(jacheng)
Comment on attachment 8801017 [details]
Bug 1309142. Part 1 - move some code to the entry action of ShutdownState.

https://reviewboard.mozilla.org/r/85826/#review84446

LGTM but the comment should be addressed.

::: dom/media/MediaDecoderStateMachine.cpp:1376
(Diff revision 1)
> +  master->mIsShutdown = true;
> +  master->mDelayedScheduler.Reset();
> +  master->mBufferedUpdateRequest.DisconnectIfExists();
> +  master->mQueuedSeek.RejectIfExists(__func__);
> +
> +  // Shutdown happens will decode timer is active, we need to disconnect and

I think the original comment has typo.

```will decode timer```?  I think it shall be ```while```. What do you think?
Attachment #8801017 - Flags: review?(jacheng) → review+
Comment on attachment 8801017 [details]
Bug 1309142. Part 1 - move some code to the entry action of ShutdownState.

https://reviewboard.mozilla.org/r/85826/#review84446

> I think the original comment has typo.
> 
> ```will decode timer```?  I think it shall be ```while```. What do you think?

Good catch!
Comment on attachment 8801018 [details]
Bug 1309142. Part 2 - add StateObject::HandleShutdown().

https://reviewboard.mozilla.org/r/85828/#review84454
Attachment #8801018 - Flags: review?(jacheng) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1d9a4dc244f
Part 1 - move some code to the entry action of ShutdownState. r=JamesCheng
https://hg.mozilla.org/integration/autoland/rev/59a5b0ac6948
Part 2 - add StateObject::HandleShutdown(). r=JamesCheng
https://hg.mozilla.org/mozilla-central/rev/f1d9a4dc244f
https://hg.mozilla.org/mozilla-central/rev/59a5b0ac6948
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.