Closed Bug 1309150 Opened 3 years ago Closed 3 years ago

[Static Analysis][Logically dead code] In function WorkerPrivateParent<Derived>::Freeze

Categories

(Core :: DOM: Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1373581)

Attachments

(1 file)

The Static Analysis tool Coverity detected that the second part of the if expression will never get evaluated:

>>    if (!allFrozen || mParentFrozen) {
>>      return true;
>>    }

This happens since |allFrozen| is set to false by default. More than this on the branch where |allFrozen| get declared the function will return since the first expression from the if statement will always be true.
Attachment #8799660 - Flags: review?(mrbkap)
Comment on attachment 8799660 [details]
Bug 1309150 - prevent dead code in WorkerPrivateParent<Derived>::Freeze when looking for frozen shared workers.

https://reviewboard.mozilla.org/r/84792/#review83834
Attachment #8799660 - Flags: review?(mrbkap) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cb958b68c84
prevent dead code in WorkerPrivateParent<Derived>::Freeze when looking for frozen shared workers. r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/7cb958b68c84
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.