Closed
Bug 1309159
Opened 8 years ago
Closed 8 years ago
Fix multiple UBSan warnings in rijndael.c
Categories
(NSS :: Test, defect)
NSS
Test
Tracking
(firefox-esr45 wontfix)
RESOLVED
FIXED
3.28
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | wontfix |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Keywords: sec-low)
We have a few unaligned pointer warnings that are easily fixed, but there's also:
rijndael.c:422:15: runtime error: left shift of 254 by 24 places cannot be represented in type 'int'
SUMMARY: AddressSanitizer: undefined-behavior rijndael.c:422:15 in [...]
The problem seems to be that SBOX() returns a PRUint8, so in SUBBYTE():
> (SBOX((w >> 24) & 0xff) << 24)
throws the warning. The left-hand operator is promoted to "int" if we don't specify PRUint32.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.28
Assignee | ||
Comment 3•8 years ago
|
||
Updated•8 years ago
|
Group: crypto-core-security → core-security-release
Updated•8 years ago
|
status-firefox-esr45:
--- → fixed
tracking-firefox-esr45:
--- → 51+
Comment 4•8 years ago
|
||
Mistakenly thought we landed 3.28.1 on the ESR-45 branch
Updated•8 years ago
|
Updated•6 years ago
|
Group: core-security-release
You need to log in
before you can comment on or make changes to this bug.
Description
•