Closed Bug 1309202 Opened 5 years ago Closed 5 years ago

stylo: Factor out branch dispatch utilities

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

It is pretty boring to write the same thing again...

I think we can at least factor the following stuffs:
* IsServo() / IsGecko() / AsServo() / AsGecko(), declarations and inline definitions
* the macros FORWARD_CONCRETE and FORWARD


The methods are relatively easy. Some macros would be enough.

The macros are a bit harder, for two things:
1. I have no idea about the naming
2. we cannot do currying on macros (can we?)
Hmmm, actually not that hard :)
Assignee: nobody → xidorn+moz
Blocks: 1309109
Comment on attachment 8799733 [details]
Bug 1309202 - Factor out stylo branch dispatch utilities.

https://reviewboard.mozilla.org/r/84870/#review84084

::: layout/style/ServoUtils.h:26
(Diff revision 1)
> +  bool IsServo() const { return false; }
> +#endif
> +
> +/**
> + * Macro used in a base class of |geckotype_| and |servotype_|.
> + * The class should defines |StyleBackendType mType;| itself.

s/defines/define/
Attachment #8799733 - Flags: review?(cam) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/802c8d996c9a
Factor out stylo branch dispatch utilities. r=heycam
https://hg.mozilla.org/mozilla-central/rev/802c8d996c9a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.