Closed
Bug 1309207
Opened 8 years ago
Closed 8 years ago
The number of total matches is not correct when search for links only
Categories
(Toolkit :: Find Toolbar, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | verified |
People
(Reporter: roxana.leitan, Assigned: mikedeboer)
References
Details
Attachments
(1 file)
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID:20161010030204 [Affected versions]: Nightly 52.0a1 [Affected platforms]: All platforms: Ubuntu 16.04, Mac OS X 10.10 , Windows 7 [Steps to reproduce]: 1.Launch Nightly 52.0a1 with a new profile. 2.Open https://wordpress.org/. 3.Press " ' " to search links only. 4.Search for "download". [Expected result]: All the matching words/characters should be found. The number of total matches should be displayed((e.g 1 of 3 matches). [Actual result]: The number of total matches is not correct.
|
Assignee | |
Comment 1•8 years ago
|
||
Funny thing that I discovered this issue this morning too, whilst looking at this code!
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Iteration: --- → 52.2 - Oct 17
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog+
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8799726 [details] Bug 1309207 - the finder iterator doesn't find occurrences properly in links-only mode. https://reviewboard.mozilla.org/r/84866/#review84164 We should have a test for this
Attachment #8799726 -
Flags: review?(jaws) → review-
|
|
Assignee | |
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93211c454a63
| Comment hidden (mozreview-request) |
|
|
||
Comment 8•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8799726 [details] Bug 1309207 - the finder iterator doesn't find occurrences properly in links-only mode. https://reviewboard.mozilla.org/r/84866/#review89796
Attachment #8799726 -
Flags: review?(jaws) → review+
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13e8eed00ceb the finder iterator doesn't find occurrences properly in links-only mode. r=jaws
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/13e8eed00ceb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
Reporter | |
Comment 11•8 years ago
|
||
Verified fixed using the latest Nightly 52.0a1 (Build ID:20161107030203) on Windows 10 x64, Mac OS X 10.11 and Ubuntu 16.04.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•