Closed
Bug 1309214
Opened 9 years ago
Closed 5 years ago
refactor CrashAggregateViewTest to reduce the memory usage
Categories
(Data Platform and Tools :: General, defect, P2)
Data Platform and Tools
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mdoglio, Unassigned)
References
Details
Running the CrashAggregates test suite requires 4GB of RAM dedicated to the JVM. It's not clear why this is happening, but it seems to have something to do with the increasing number of dimensions in the test fixtures.
Reporter | ||
Comment 1•9 years ago
|
||
Note to myself: also add a testcase for pings with missing dimensions.
Updated•8 years ago
|
Component: Metrics: Pipeline → Datasets: Crash Aggregates
Product: Cloud Services → Data Platform and Tools
Comment 2•8 years ago
|
||
My guess is it's the fact that we're generating a unique ping for every possible combination of these dimensions:
https://github.com/mozilla/telemetry-batch-view/blob/4f1563d/src/test/scala/com/mozilla/telemetry/CrashAggregateViewTest.scala#L15
https://github.com/mozilla/telemetry-batch-view/blob/4f1563d/src/test/scala/com/mozilla/telemetry/CrashAggregateViewTest.scala#L154
That adds up to 98304 pings. Depending on the exact size of each ping, we could easily get into hundreds of megabytes or even gigabytes (2k per ping = 200M, 20k per ping = 2G)
Do we really need every combination here for the test to be valid?
Flags: needinfo?(mdoglio)
Reporter | ||
Comment 3•8 years ago
|
||
I don't think we do. I would put this bug on hold for now, as bug 1357793 may make this one a WONTFIX.
Flags: needinfo?(mdoglio)
Comment 4•7 years ago
|
||
Component: Datasets: Crash Aggregates → Datasets: General
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•3 years ago
|
Component: Datasets: General → General
You need to log in
before you can comment on or make changes to this bug.
Description
•