1309228 - [geckoview] Remove moar JavaPanZoomController (JPZ) from mobile/android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1307522 +++

There's more JPZ goop that can be removed. Specifically:
setScrollClampingSize in browser.js, which allows removing
gScreenWidth/gScreenHeight in browser.js, which allows removing
the window arguments code that passes in width and height

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1309228 - Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ.

Also this makes the gScreenWidth/gScreenHeight variables unused, so those can
come out too and the Window:Resize handler can be simplified a bit.

Review commit: https://reviewboard.mozilla.org/r/84892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84892/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1309228 - Now that the width and height arguments are no longer needed in browser.js, remove those too.

Review commit: https://reviewboard.mozilla.org/r/84894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84894/

Comment 3

[Randall Barker [:rbarker]]

Comment on attachment 8799769 [details]
Bug 1309228 - Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ.

https://reviewboard.mozilla.org/r/84892/#review83512

Comment 4

[Randall Barker [:rbarker]]

Comment on attachment 8799770 [details]
Bug 1309228 - Now that the width and height arguments are no longer needed in browser.js, remove those too.

https://reviewboard.mozilla.org/r/84894/#review83514

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/650200515d54
Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ. r=rbarker
https://hg.mozilla.org/integration/autoland/rev/b01926251add
Now that the width and height arguments are no longer needed in browser.js, remove those too. r=rbarker

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/650200515d54
https://hg.mozilla.org/mozilla-central/rev/b01926251add

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8799769 [details]
Bug 1309228 - Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ.

https://reviewboard.mozilla.org/r/84892/#review85062

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8799770 [details]
Bug 1309228 - Now that the width and height arguments are no longer needed in browser.js, remove those too.

https://reviewboard.mozilla.org/r/84894/#review85064