[geckoview] Remove moar JavaPanZoomController (JPZ) from mobile/android

RESOLVED FIXED in Firefox 52

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

52 Branch
Firefox 52
All
Android
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #1307522 +++

There's more JPZ goop that can be removed. Specifically:
setScrollClampingSize in browser.js, which allows removing
gScreenWidth/gScreenHeight in browser.js, which allows removing
the window arguments code that passes in width and height
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Priority: -- → P3
Hardware: Unspecified → All

Comment 3

2 years ago
mozreview-review
Comment on attachment 8799769 [details]
Bug 1309228 - Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ.

https://reviewboard.mozilla.org/r/84892/#review83512
Attachment #8799769 - Flags: review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8799770 [details]
Bug 1309228 - Now that the width and height arguments are no longer needed in browser.js, remove those too.

https://reviewboard.mozilla.org/r/84894/#review83514
Attachment #8799770 - Flags: review+

Comment 5

2 years ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/650200515d54
Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ. r=rbarker
https://hg.mozilla.org/integration/autoland/rev/b01926251add
Now that the width and height arguments are no longer needed in browser.js, remove those too. r=rbarker

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/650200515d54
https://hg.mozilla.org/mozilla-central/rev/b01926251add
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Comment 7

2 years ago
mozreview-review
Comment on attachment 8799769 [details]
Bug 1309228 - Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ.

https://reviewboard.mozilla.org/r/84892/#review85062
Attachment #8799769 - Flags: review?(snorp) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8799770 [details]
Bug 1309228 - Now that the width and height arguments are no longer needed in browser.js, remove those too.

https://reviewboard.mozilla.org/r/84894/#review85064
Attachment #8799770 - Flags: review?(snorp) → review+
You need to log in before you can comment on or make changes to this bug.