Closed Bug 1309239 Opened 3 years ago Closed 3 years ago

Don't check for Xray slot bits for interfaces that never have Xrays

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Andrea noticed this in bug 1308956.  We don't include XrayWrapper.h if the interface doesn't want Xrays, but the code we spit out in the getter still checks for them.  Simple fix coming up.
Attachment #8799760 - Flags: review?(amarchesini) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eeb973656fa
Fix the codegen for a cached DOM getter to not worry about Xrays if the interface doesn't want Xrays (i.e. is not mainthread-exposed).  r=baku
https://hg.mozilla.org/mozilla-central/rev/7eeb973656fa
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.