1309245 - tc-gh not firing for pull requests

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[[e-mail] (:bhearsum)]

I think this broke sometime over the weekend. I have a couple of PRs that don't have jobs: https://github.com/mozilla/balrog/pull/142, https://github.com/mozilla/balrog/pull/138 (the latter's commit was only pushed over the weekend, not 8 days ago as it seems to suggest).

Jobs are still triggered on commits to master: https://github.com/mozilla/balrog/commit/4f10035983a747f3bddac771c08c5dbed1dcab44

Comment 1

[Rok Garbas [:garbas]]

same here https://github.com/mozilla-releng/services/pull/64

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

It is creating the tasks, just not reporting correctly:

2016-10-11T14:23:26.713747+00:00 app[worker.1]: Tue, 11 Oct 2016 14:23:26 GMT taskcluster-client:PulseListener Failed to process message {"payload":{"status":{"taskGraphId":"BxpPbUWKR9S23UDLuQwBOw","schedulerId":"task-graph-scheduler","state":"running"},"version":1},"exchange":"exchange/taskcluster-scheduler/v1/task-graph-running","routingKey":"primary._._._._._._.task-graph-scheduler.BxpPbUWKR9S23UDLuQwBOw._","redelivered":false,"routes":["taskcluster-github.taskcluster.migration.a2590e3364d60d2fd1190f8592ce2b6b2de7fd58"],"routing":{"routingKeyKind":"primary","taskId":"_","runId":"_","workerGroup":"_","workerId":"_","provisionerId":"_","workerType":"_","schedulerId":"task-graph-scheduler","taskGraphId":"BxpPbUWKR9S23UDLuQwBOw","reserved":"_"}} from exchange/taskcluster-scheduler/v1/task-graph-running with error: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"}, as JSON: {"code":404,"status":"Not Found","message":"{\"message\":\"Not Found\",\"documentation_url\":\"https://developer.github.com/v3\"}"} undefined

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Hm, that may be unrelated:
 - seems only to affect that repo (taskcluster/migration)
 - for pushes, not PRs

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Yep, unrealted.  Ben is seeing

2016-10-11T14:44:33.068306+00:00 app[worker.1]: Tue, 11 Oct 2016 14:44:33 GMT taskcluster-github handling pull_request.assigned webhook for: mozilla/balrog
2016-10-11T14:44:33.119513+00:00 app[worker.1]: Tue, 11 Oct 2016 14:44:33 GMT taskcluster-github intree config compiled with zero tasks. Skipping

Comment 5

[Brian Stack [:bstack]]

09:47:16 <bstack> bhearsum: ok, try doing the unassign/reassign thing you did on your PR again?
09:47:40 <bhearsum> bstack: just did it on https://github.com/mozilla/balrog/pull/142
09:48:00 <bstack> woo!
09:48:04 <bstack> looks like it worked, yeah?
09:48:54 <rail> jhford: thanks! it worked, just needed to uses DELETE instead of GET :)
09:49:21 <bhearsum> bstack: ah yes, there it is!
09:49:22 <bstack> The "pull_request.*" syntax was unknown to me and untested so I broke it in a refactor. There's now  a test for it and it should work from here on out.
09:49:25 <bhearsum> it took a second to show up, but i see it now
09:49:32 <bhearsum> thanks so much for the quick fix


https://github.com/taskcluster/taskcluster-github/commit/0de5e134200b250ec7729cae592cc985a7e21812#diff-b0c5919fd2e937bb62dceb0858dcc736L100