1309297 - On about:profiles, "Show Folder" (Windows) is misleading

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Ton [:Tonnes]]

+++ This bug was initially created as a clone of Bug #1300562 +++

In bug 1300562, the wording for opening the profile folder in about:support was changed from "Show Folder" to "Open folder" to match what’s intended - the profile folder itself is opened, not its parent.

My bad perhaps, but I found similar strings recently for the same purpose in about:profiles, and the issue is also valid there. It’s therefor obvious the string should be changed to match "Open folder" for Windows as well since the same folder is opened, so the strings are currently inconsistent.

STR:
- Open about:support on Windows
- Note the string "Open Folder" (after "Profile Folder")
- Open about:profiles on Windows
- Note the string "Show Folder" (after "Root/Local Directory")

Expected:
Both strings should use "Open Folder".

Mac/Linux should be OK. Please change "Show Folder" to "Open Folder" in about:profiles (winOpenDir) for Windows.

Comment 1

[Ton [:Tonnes]]

Attachment: bug_1309297_mc.patch

I think this should do it.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8799885 [details] [diff] [review]
bug_1309297_mc.patch

Review of attachment 8799885 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/19fe45006bdb
Change "Show Folder" to "Open Folder" (about:profiles) in Windows. r=mossop

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/19fe45006bdb