Closed
Bug 1309318
Opened 8 years ago
Closed 8 years ago
Make the httpd server from BaseMarionetteTestRunner available to TestCase class
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox52 fixed)
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: Silne30, Assigned: whimboo)
References
Details
Attachments
(1 file)
Right now, there is no way for a TestCase to access the httpd instance that is started in BaseMarionetteTestRunner. We need to be able to do this so that we can add behavior to the server and register handlers.
|
Assignee | |
Comment 1•8 years ago
|
||
David, do you have any concerns with that? Does the MarionetteTestCase class sound fine to you? I don't see why it needs to be part of the Marionette object.
Flags: needinfo?(dburns)
|
||
Comment 2•8 years ago
|
||
This should be fine. My only thing that we can not do is add it to the Marionette object. If you can get this through the harness then go for it. ask Maja for review.
Flags: needinfo?(dburns)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•8 years ago
|
||
The try build for the second last update of this patch works fine now with the Marionette client unit tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=750fbc004b23 Sadly my httpd mock changes have gotten lost so the harness unit tests are failing. I will issue a new try build based on that now.
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8805541 -
Flags: review?(mjzffr)
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805541 [details] Bug 1309318 - Make the httpd server available to TestCase class to allow custom handlers. https://reviewboard.mozilla.org/r/89310/#review89838
Attachment #8805541 -
Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e6ef4bbe35a Make the httpd server available to TestCase class to allow custom handlers. r=maja_zf
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6e6ef4bbe35a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•