Closed Bug 1309348 Opened 3 years ago Closed 2 years ago

beetmover should verify downloaded files

Categories

(Release Engineering :: Release Automation: Other, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Unassigned)

References

Details

In Firefox 50.0b6 we hit an issue where beetmover download a corrupted file from TC artifacts (cloud-mirror) and copied it to the candidates directory. The file was 33M instead of 86M. We have to request a purge in bug 1309252 twice, because it wasn't clear why the file was corrupted.

I had to use a "one click loaner" to get all redirect URLs to cloud-mirror, so I can purge the file. I replaced /redirect/ with /purge/ (see cloud-mirror's API) and use "curl -X DELETE ..." to purge the file.

It would be great to:

* print out all redirects, so we can purge files without a loaner

* verify the files somehow. This is tricky...
** we can use checksums if the file is there
** we can check file integrity depending on the format:
*** mar: mar -t?
*** exe, dmg: 7z t?
*** etc.
Once bug 1317747 is done, we'll know all our downloaded files match the chain of trust SHAs.  If that's your main concern, that should solve this bug.
(In reply to Aki Sasaki [:aki] from comment #1)
> Once bug 1317747 is done, we'll know all our downloaded files match the
> chain of trust SHAs.  If that's your main concern, that should solve this
> bug.

(once release promotion uses scriptworkers)
Priority: -- → P4
Summary: beetmover should verify downloaded files if possible → beetmover should verify downloaded files
(In reply to Aki Sasaki [:aki] from comment #2)
> (In reply to Aki Sasaki [:aki] from comment #1)
> > Once bug 1317747 is done, we'll know all our downloaded files match the
> > chain of trust SHAs.  If that's your main concern, that should solve this
> > bug.
> 
> (once release promotion uses scriptworkers)

(Which is Fx59+)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.