Closed Bug 1309372 Opened 5 years ago Closed 4 years ago
Wrong Lightning version in Sea
Monkey 2 .46 build 6 Release Candidate
Release candidate seems to work fine but shows a wrong .4.46 version for Lightning. Downloaded from here: https://archive.mozilla.org/pub/seamonkey/candidates/2.46-candidates/build6/unsigned/win32/en-US/
OS: Unspecified → Windows
Summary: Wrong Lightning version in build 6 2.46 release Ccndidate → Wrong Lightning version in 2.46 build 6 Release Candidate
Possibly a duplicate or followup of bug 1293943.
Fallen, wrt your comment yesterday on irc. Can the use of MOZ_PKG_VERSION be dropped from the makefile code which generates the Lightning version? I think the Thunderbird version is always accessible/usable or not? FRG
It was probably added for a reason. I assume that reason is that for release or beta builds, MOZ_PKG_VERSION may be set to something different than in version.txt
Hmm, what do you suggest? Maybe testing for SeaMonkey, setting a different variable with the content of MOZ_PKG_VERSION when not SeaMonkey and use this for version generation? Or changing makeversion.py to detect the SeaMonkey version?
You could try an if/else block that uses what we are doing now for Thunderbird and ignoring MOZ_PKG_VERSION otherwise. In the worst case this may mean wrong version numbers in the Seamonkey builds in situations where building Thunderbird on the same tree would have a difference between MOZ_PKG_VERSION and version.txt. If you are making changes to both lightning and gdata Makefiles, you might also want to refactor all the version variables into calendar/lightning/versions.mk and include from both.
[Approval Request Comment] Regression caused by (bug #): User impact if declined: Seamonkey release builds include a lightning with wrong version information. Testing completed (on m-c, etc.): c-r Risk to taking this patch (and alternatives if risky): low String changes made by this patch: none
Product: SeaMonkey → Calendar
Version: SeaMonkey 2.46 Branch → Trunk
Summary: Wrong Lightning version in 2.46 build 6 Release Candidate → Wrong Lightning version in SeaMonkey 2.46 build 6 Release Candidate
Can you do a Thunderbird try run for this?
I likely didn't use the right try syntax to build all platforms but the patch looks ok to me. The bustage in the x64 test is from a different bug. Checking the logs I see -DLIGHTNING_VERSION=5.4a1 which is the expected result. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6277ffac4e6503d78a84a5ba0924079b694973d7
Attachment #8805837 - Flags: review?(philipp)
Attachment #8805837 - Flags: review+
Attachment #8805837 - Flags: approval-calendar-beta?(philipp)
Attachment #8805837 - Flags: approval-calendar-beta+
Attachment #8805837 - Flags: approval-calendar-aurora?(philipp)
Attachment #8805837 - Flags: approval-calendar-aurora+
https://hg.mozilla.org/comm-central/rev/807b9f10a95cba9260196561fb9c3fc719ef54c9 I will wait till tomorrow and push them to the branches then.
Target Milestone: --- → 5.5
https://hg.mozilla.org/releases/comm-aurora/rev/855b5d14f40eeace2f785c8402c547d10157f44b https://hg.mozilla.org/releases/comm-beta/rev/325cc1eb915498dff0b15a2cd594640827829212 c-r approval via irc https://hg.mozilla.org/releases/comm-release/rev/98e75b3d030b0fb0ac52bc97a9db0b4e48175b1a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.