Remove nsIPrintOptions::ShowPrintSetupDialog

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

3.02 KB, patch
vlad
: review+
Details | Diff | Splinter Review
Posted file patch (obsolete) —
Myk, requesting review from you since I suspect this was something to do with embedding.
Attachment #8800004 - Flags: review?(myk)
Posted patch patchSplinter Review
(without unrelated nsDeviceContextSpecX.mm changes)
Attachment #8800004 - Attachment is obsolete: true
Attachment #8800004 - Flags: review?(myk)
Attachment #8800005 - Flags: review?(myk)
It looks like nsIPrintOptions can also go away if this removal is okay, but I'll do that separately.
Comment on attachment 8800005 [details] [diff] [review]
patch

Review of attachment 8800005 [details] [diff] [review]:
-----------------------------------------------------------------

nsIPrintOptions::ShowPrintSetupDialog isn't used over in comm-central either.  It may well have been an embedding API, and removing it seems reasonable to me, but I'm not a peer for widget/, so feedback+ from me and review? for Vlad.
Attachment #8800005 - Flags: review?(vladimir)
Attachment #8800005 - Flags: review?(myk)
Attachment #8800005 - Flags: feedback+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da1c0184e9f5
Remove nsIPrintOptions::ShowPrintSetupDialog. r=vlad, f=myk
Blocks: 1313525
https://hg.mozilla.org/mozilla-central/rev/da1c0184e9f5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.