Closed
Bug 1309397
Opened 8 years ago
Closed 8 years ago
Remove nsIPrintOptions::ShowPrintSetupDialog
Categories
(Core :: Printing: Setup, defect)
Core
Printing: Setup
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file, 1 obsolete file)
3.02 KB,
patch
|
vlad
:
review+
myk
:
feedback+
|
Details | Diff | Splinter Review |
It looks like nsIPrintOptions::ShowPrintSetupDialog is now dead code: https://dxr.mozilla.org/mozilla-central/search?q=ShowPrintSetupDialog https://dxr.mozilla.org/addons/search?q=ShowPrintSetupDialog&redirect=true
Assignee | ||
Comment 1•8 years ago
|
||
Myk, requesting review from you since I suspect this was something to do with embedding.
Attachment #8800004 -
Flags: review?(myk)
Assignee | ||
Comment 2•8 years ago
|
||
(without unrelated nsDeviceContextSpecX.mm changes)
Attachment #8800004 -
Attachment is obsolete: true
Attachment #8800004 -
Flags: review?(myk)
Attachment #8800005 -
Flags: review?(myk)
Assignee | ||
Comment 3•8 years ago
|
||
It looks like nsIPrintOptions can also go away if this removal is okay, but I'll do that separately.
Comment 4•8 years ago
|
||
Comment on attachment 8800005 [details] [diff] [review] patch Review of attachment 8800005 [details] [diff] [review]: ----------------------------------------------------------------- nsIPrintOptions::ShowPrintSetupDialog isn't used over in comm-central either. It may well have been an embedding API, and removing it seems reasonable to me, but I'm not a peer for widget/, so feedback+ from me and review? for Vlad.
Attachment #8800005 -
Flags: review?(vladimir)
Attachment #8800005 -
Flags: review?(myk)
Attachment #8800005 -
Flags: feedback+
Attachment #8800005 -
Flags: review?(vladimir) → review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/da1c0184e9f5 Remove nsIPrintOptions::ShowPrintSetupDialog. r=vlad, f=myk
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/da1c0184e9f5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•