Closed
Bug 1309414
Opened 8 years ago
Closed 5 years ago
Fix Makefile warnings lib/freebl/Makefile
Categories
(NSS :: Build, defect, P3)
Tracking
(Not tracked)
RESOLVED
INACTIVE
People
(Reporter: u480271, Assigned: u480271)
Details
Attachments
(2 files)
The Makefile in lib/freebl specifies the same target twice producing a warning: cd freebl; make libs make[3]: Entering directory '/home/djg/Mozilla/gecko/security/nss/lib/freebl' Makefile:648: warning: overriding recipe for target '/home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/security/nss/lib/freebl' Makefile:635: warning: ignoring old recipe for target '/home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/security/nss/lib/freebl' /home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/config/nsinstall -R -m 664 /home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/sec urity/nss/lib/freebl/libfreebl.a /home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/dist/lib mkdir /home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/security/nss/lib/freebl mkdir: cannot create directory ‘/home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/security/nss/lib/freebl’: File exists Makefile:648: recipe for target '/home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/security/nss/lib/freebl' failed make[3]: [/home/djg/Mozilla/gecko/objdir-desktop-debug.noindex/security/nss/lib/freebl] Error 1 (ignored) This is because both FREEBL_BUILD_SINGLE_SHLIB and NEED_STUB_BUILD are defined.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
I am not a build-config peer any longer. I don't know who is the right person to review NSS build changes, but please try gps.
|
|
||
Updated•8 years ago
|
Attachment #8800031 -
Flags: review?(benjamin)
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8800031 [details] Bug 1309414 - Specify SINGLE_SHLIB_DIR only once. https://reviewboard.mozilla.org/r/85040/#review85410 NSS has its own submission process. You'll need to submit a patch against https://hg.mozilla.org/projects/nss and it will eventually makes its way into mozilla-central.
Attachment #8800031 -
Flags: review?(gps) → review-
|
|
||
Comment 5•8 years ago
|
||
Tim: can you please help Dan with NSS submission foo (I'm not sure what tools you are all using these days). FWIW, if you want MozReview support for NSS, it is easy to set up: someone just needs to ask.
Flags: needinfo?(ttaubert)
|
||
Comment 6•8 years ago
|
||
Dan, I'm happy to help you get this patch into NSS. Can you please create a new version of it, against hg.mozilla.org/projects/nss, and attach a patch file to this bug? We're still in the process of figuring out what works for us, so Bugzilla is probably best for now :) Thanks!
Flags: needinfo?(ttaubert) → needinfo?(dglastonbury)
Thanks Tim, I'll get a patch up against hg.mozilla.org/projects/nss.
Flags: needinfo?(dglastonbury)
If $(FREEBL_BUILD_SINGLE_SHLIB) or $(NEED_STUB_BUILD) are defined, the target $(SINGLE_SHLIB_DIR): is defined, causing a warning about overriding recipe. This change specifies target $(SINGLE_SHLIB_DIR) only once.
Attachment #8803767 -
Flags: review?(ttaubert)
|
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8803767 [details] [diff] [review] Specify SINGLE_SHLIB_DIR only once Review of attachment 8803767 [details] [diff] [review]: ----------------------------------------------------------------- ::: lib/freebl/Makefile @@ +630,5 @@ > +ifneq "$(or $(FREEBL_BUILD_SINGLE_SHLIB),$(NEED_STUB_BUILD))" "" > +SINGLE_SHLIB_DIR = $(OBJDIR)/$(OS_TARGET)_SINGLE_SHLIB > +ALL_TRASH += $(SINGLE_SHLIB_DIR) > +$(SINGLE_SHLIB_DIR): > + -mkdir $(SINGLE_SHLIB_DIR) Let's keep the `-mkdir -p $(SINGLE_SHLIB_DIR)` from NEED_STUB_BUILD. That should work for both cases.
Attachment #8803767 -
Flags: review?(ttaubert) → feedback+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•