Closed Bug 1309430 Opened 8 years ago Closed 3 months ago

Some mpadded reftests assume that all monospace characters are from the same font

Categories

(Core :: MathML, defect, P5)

defect

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox52 --- wontfix
firefox124 --- fixed

People

(Reporter: karlt, Assigned: fredw)

References

Details

Attachments

(1 file)

See
layout/reftests/mathml/mpadded-7.html
layout/reftests/mathml/mpadded-8.html
layout/reftests/mathml/mpadded-9.html in
https://treeherder.mozilla.org/logviewer.html#?job_id=28924854&repo=try#L22912
triggered by changes for bug 1309086.
Too late for firefox 52, mass-wontfix.
Severity: normal → S3

These tests were initially added in bug 685628, and were relying
on <mtext mathvariant="monospace"> so we can assume that all
glyphs have the same logical width/height even if they may have
different ink width/height.

At that time mathvariant="monospace" was probably always using
font-family: monospace but after bug 114365, these were generally
directly mapped to Mathematical Alphanumeric Symbols and sometimes
they were falling back to the old font-family: monospace. Tests
were added to continue checking the latter too. After bug 1846482,
the one using the legacy mathvariant="monospace" were just
replaced with direct use of Mathematical Alphanumeric Symbols.

To keep the spirit of the original tests, we just need a font
with two glyphs with same logical width/height but different ink
width/height.

Probably the easiest solution is to only keep the tests with
monospace Mathematical Alphanumeric Symbols. We should have fonts
for that in modern systems, except maybe on Android. But even if Tofu
glyphs are used, the tests will probably pass. If not, we could still
create a custom WOFF font for the sake of these tests.

These tests were initially added in bug 685628, and were relying
on <mtext mathvariant="monospace"> so we can assume that all
glyphs have the same logical width/height even if they may have
different ink width/height.

At that time mathvariant="monospace" was probably always using
font-family: monospace but after bug 114365, these were generally
directly mapped to Mathematical Alphanumeric Symbols and sometimes
they were falling back to the old font-family: monospace. Tests
were added to continue checking the latter too. After bug 1846482,
the one using the legacy mathvariant="monospace" were just
replaced with direct use of Mathematical Alphanumeric Symbols.

Assignee: nobody → fwang
Attachment #9377958 - Attachment description: WIP: Bug 1309430 - Remove font-family: monospace from some mpadded reftests. r=emilio → Bug 1309430 - Remove font-family: monospace from some mpadded reftests. r=emilio
Status: NEW → ASSIGNED
Pushed by fwang@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/d748f63d4f05
Remove font-family: monospace from some mpadded reftests. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: