Closed
Bug 130944
Opened 24 years ago
Closed 24 years ago
remove unused scary code that's bothering people
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: timeless, Assigned: danm.moz)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
4.85 KB,
patch
|
timeless
:
review+
jst
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
i'm dipping into embedding again. while trying to write a js proxy component, i've started to add some debugging statements in the c++ windowwatcher class (which i need to proxy).
Are there any plans to resurrect the code after the return, or can I commit a patch to remove it?
|
||
Comment 2•24 years ago
|
||
Attachment #74141 -
Flags: review+
better: get rid of the whole method and clean up a couple of misleading
comments while you're at it.
Attachment #74141 -
Attachment is obsolete: true
Comment on attachment 74194 [details] [diff] [review]
remove unused method
r=timeless
Attachment #74194 -
Flags: review+
|
||
Comment 5•24 years ago
|
||
Comment on attachment 74194 [details] [diff] [review]
remove unused method
sr=jst if you make the GetWebBrowser() methods null out the out parameter.
Attachment #74194 -
Flags: superreview+
|
|
||
Updated•24 years ago
|
QA Contact: mdunn → depstein
Status: NEW → ASSIGNED
Summary: scary code → remove unused scary code that's bothering people
Target Milestone: --- → mozilla1.0
|
||
Comment 6•24 years ago
|
||
Comment on attachment 74194 [details] [diff] [review]
remove unused method
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #74194 -
Flags: approval+
.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•24 years ago
|
||
nsWindowWatcher::InitializeDocshell() removed. Verified against 3/18/02 Mozilla
0.9.9 debug build.
Status: RESOLVED → VERIFIED
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•