remove unused scary code that's bothering people

VERIFIED FIXED in mozilla1.0

Status

()

Core
Embedding: APIs
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: timeless, Assigned: Dan M)

Tracking

Trunk
mozilla1.0
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
i'm dipping into embedding again. while trying to write a js proxy component, i've started to add some debugging statements in the c++ windowwatcher class (which i need to proxy).

Are there any plans to resurrect the code after the return, or can I commit a patch to remove it?
(Reporter)

Comment 1

16 years ago
Created attachment 74141 [details] [diff] [review]
remove unreachable code

Comment 2

16 years ago
Comment on attachment 74141 [details] [diff] [review]
remove unreachable code

r=rpotts@netscape.com
Attachment #74141 - Flags: review+
(Assignee)

Comment 3

16 years ago
Created attachment 74194 [details] [diff] [review]
remove unused method

better: get rid of the whole method and clean up a couple of misleading
comments while you're at it.
Attachment #74141 - Attachment is obsolete: true
(Reporter)

Comment 4

16 years ago
Comment on attachment 74194 [details] [diff] [review]
remove unused method

r=timeless
Attachment #74194 - Flags: review+
Comment on attachment 74194 [details] [diff] [review]
remove unused method

sr=jst if you make the GetWebBrowser() methods null out the out parameter.
Attachment #74194 - Flags: superreview+

Updated

16 years ago
QA Contact: mdunn → depstein
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Summary: scary code → remove unused scary code that's bothering people
Target Milestone: --- → mozilla1.0

Comment 6

16 years ago
Comment on attachment 74194 [details] [diff] [review]
remove unused method

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #74194 - Flags: approval+
(Assignee)

Comment 7

16 years ago
.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 8

16 years ago
nsWindowWatcher::InitializeDocshell() removed. Verified against 3/18/02 Mozilla
0.9.9 debug build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.