1309440 - Remove unused BitBuffer methods from RiceDeltaDecoder.cpp

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[:Cykesiopka]

There errors are generated on a GCC6 and --enable-warnings-as-errors build:
> /moz/mozilla-inbound/toolkit/components/url-classifier/RiceDeltaDecoder.cpp:298:6: error: ‘bool {anonymous}::BitBuffer::Seek(size_t, size_t)’ defined but not used [-Werror=unused-function]
> bool BitBuffer::Seek(size_t byte_offset, size_t bit_offset) {
>      ^~~~~~~~~
> /moz/mozilla-inbound/toolkit/components/url-classifier/RiceDeltaDecoder.cpp:290:6: error: ‘void {anonymous}::BitBuffer::GetCurrentOffset(size_t*, size_t*)’ defined but not used [-Werror=unused-function]
> void BitBuffer::GetCurrentOffset(
>      ^~~~~~~~~
> /moz/mozilla-inbound/toolkit/components/url-classifier/RiceDeltaDecoder.cpp:277:6: error: ‘bool {anonymous}::BitBuffer::ReadSignedExponentialGolomb(int32_t*)’ defined but not used [-Werror=unused-function]
> bool BitBuffer::ReadSignedExponentialGolomb(int32_t* val) {
>      ^~~~~~~~~
> /moz/mozilla-inbound/toolkit/components/url-classifier/RiceDeltaDecoder.cpp:241:6: error: ‘bool {anonymous}::BitBuffer::ConsumeBytes(size_t)’ defined but not used [-Werror=unused-function]
> bool BitBuffer::ConsumeBytes(size_t byte_count) {
>      ^~~~~~~~~
> /moz/mozilla-inbound/toolkit/components/url-classifier/RiceDeltaDecoder.cpp:203:6: error: ‘bool {anonymous}::BitBuffer::ReadUInt32(uint32_t*)’ defined but not used [-Werror=unused-function]
> bool BitBuffer::ReadUInt32(uint32_t* val) {
>      ^~~~~~~~~
> /moz/mozilla-inbound/toolkit/components/url-classifier/RiceDeltaDecoder.cpp:193:6: error: ‘bool {anonymous}::BitBuffer::ReadUInt16(uint16_t*)’ defined but not used [-Werror=unused-function]
> bool BitBuffer::ReadUInt16(uint16_t* val) {
>      ^~~~~~~~~
> /moz/mozilla-inbound/toolkit/components/url-classifier/RiceDeltaDecoder.cpp:183:6: error: ‘bool {anonymous}::BitBuffer::ReadUInt8(uint8_t*)’ defined but not used [-Werror=unused-function]
> bool BitBuffer::ReadUInt8(uint8_t* val) {
>      ^~~~~~~~~

I would like to remove these methods so a local patch isn't necessary just to build.

Comment 1

[:Cykesiopka]

Attachment: Bug 1309440 - Remove unused BitBuffer methods from RiceDeltaDecoder.cpp.

Review commit: https://reviewboard.mozilla.org/r/85052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85052/

Comment 2

[François Marier [:francois]]

(In reply to :Cykesiopka from comment #0)
> I would like to remove these methods so a local patch isn't necessary just
> to build.

Henry, does that work for you too or do you think we might need these functions later?

Comment 3

[Henry Chang [:hchang]]

I don't think we need these functions so it's fine to remove them. Thanks for helping do that!

Comment 4

[François Marier [:francois]]

Comment on attachment 8800043 [details]
Bug 1309440 - Remove unused BitBuffer methods from RiceDeltaDecoder.cpp.

https://reviewboard.mozilla.org/r/85052/#review83838

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7be803449716
Remove unused BitBuffer methods from RiceDeltaDecoder.cpp. r=francois

Comment 6

[:Cykesiopka]

Thanks as well!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7be803449716