Closed Bug 1309508 Opened 3 years ago Closed 3 years ago

Remove ToggleEventDispatcher and FormPasswordEventDispatcher classes that could be replaced by AsyncEventRunning() approach

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: edgar, Assigned: edgar)

Details

Attachments

(2 files, 2 obsolete files)

+++ This bug was initially created as a follow-up of Bug 1308069 Comment #13 +++

We settled on a generic approach in Bug 1308069 Comment #13:
1) Add a virtual AsyncEventRunning(AsyncEventDispatcher*) function on EventTarget.  Have the default impl on EventTarget do nothing.
2) In AsyncEventDispatcher::Run, right after the early return if canceled, call AsyncEventRunning() on mTarget.
3) Override AsyncEventRunning() here to null out your pointer.

Filed this followup bug to remove the existing ToggleEventDispatcher and FormPasswordEventDispatcher classes that could move to the new setup instead.
Attachment #8800552 - Attachment description: Part 1: Remove FormPasswordEventDispatcher class, v1 → Part 1: Remove ToggleEventDispatcher class, v1
Comment on attachment 8800552 [details] [diff] [review]
Part 1: Remove ToggleEventDispatcher class, v1

r=me
Attachment #8800552 - Flags: review+
Comment on attachment 8800553 [details] [diff] [review]
Part 2: Remove FormPasswordEventDispatcher class, v1

r=me. Thank you for doing this!
Attachment #8800553 - Flags: review+
Attachment #8800552 - Attachment is obsolete: true
Attachment #8801988 - Flags: review+
Attachment #8800553 - Attachment is obsolete: true
Attachment #8801989 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab9305506355
Part 1: Remove ToggleEventDispatcher class that could be replaced by AsyncEventRunning() approach. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/524f34c3de31
Part 2: Remove FormPasswordEventDispatcher class that could be replaced by AsyncEventRunning() approach. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ab9305506355
https://hg.mozilla.org/mozilla-central/rev/524f34c3de31
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.