Closed
Bug 1309508
Opened 8 years ago
Closed 8 years ago
Remove ToggleEventDispatcher and FormPasswordEventDispatcher classes that could be replaced by AsyncEventRunning() approach
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
Details
Attachments
(2 files, 2 obsolete files)
|
2.97 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
|
4.04 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a follow-up of Bug 1308069 Comment #13 +++ We settled on a generic approach in Bug 1308069 Comment #13: 1) Add a virtual AsyncEventRunning(AsyncEventDispatcher*) function on EventTarget. Have the default impl on EventTarget do nothing. 2) In AsyncEventDispatcher::Run, right after the early return if canceled, call AsyncEventRunning() on mTarget. 3) Override AsyncEventRunning() here to null out your pointer. Filed this followup bug to remove the existing ToggleEventDispatcher and FormPasswordEventDispatcher classes that could move to the new setup instead.
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8800552 -
Attachment description: Part 1: Remove FormPasswordEventDispatcher class, v1 → Part 1: Remove ToggleEventDispatcher class, v1
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8800552 [details] [diff] [review] Part 1: Remove ToggleEventDispatcher class, v1 r=me
Attachment #8800552 -
Flags: review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8800553 [details] [diff] [review] Part 2: Remove FormPasswordEventDispatcher class, v1 r=me. Thank you for doing this!
Attachment #8800553 -
Flags: review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8800552 -
Attachment is obsolete: true
Attachment #8801988 -
Flags: review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
Attachment #8800553 -
Attachment is obsolete: true
Attachment #8801989 -
Flags: review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1401e28c986362b83f7170d9108a4692a1b5de67&filter-tier=1&group_state=expanded
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab9305506355 Part 1: Remove ToggleEventDispatcher class that could be replaced by AsyncEventRunning() approach. r=bz https://hg.mozilla.org/integration/mozilla-inbound/rev/524f34c3de31 Part 2: Remove FormPasswordEventDispatcher class that could be replaced by AsyncEventRunning() approach. r=bz
Keywords: checkin-needed
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ab9305506355 https://hg.mozilla.org/mozilla-central/rev/524f34c3de31
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•