Remove MFR::mDemuxerInitDone

RESOLVED INVALID

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: kaku, Assigned: kaku)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

2 years ago
MFR::mDemuxerInitDone is only read here:
http://searchfox.org/mozilla-central/rev/e8dd21b1673c07307068303ab3e99360c78f4d12/dom/media/MediaFormatReader.cpp#1922

And |MFR::mDemuxerInitDone| should be equivalent to |mDemuxerInitRequest.Exists()|.

I think we can just remove MFR::mDemuxerInitDone.
(Assignee)

Updated

2 years ago
Blocks: 1309516
(Assignee)

Updated

2 years ago
Assignee: nobody → kaku
It (In reply to Tzuhao Kuo [:kaku] from comment #0)
> MFR::mDemuxerInitDone is only read here:
> http://searchfox.org/mozilla-central/rev/
> e8dd21b1673c07307068303ab3e99360c78f4d12/dom/media/MediaFormatReader.cpp#1922
> 
> And |MFR::mDemuxerInitDone| should be equivalent to
> |mDemuxerInitRequest.Exists()|.
> 

It is not equivalent. 

mDemuxerInitDone indicates that the initialisation completed and succeeded. 
Checking that the request exists only give you that information, it doesn't tell you if it has finished and succeeded. 

Check the blame for this line, you will find the bug where this check was added because distinguishing both condition is inportant
> I think we can just remove MFR::mDemuxerInitDone.
(Assignee)

Comment 2

2 years ago
Yes, you're right. I did not consider it carefully, will close this bug.
Priority: -- → P3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.