1309517 - Remove MFR::mDemuxerInitDone

Status: RESOLVED INVALID

(Core :: Audio/Video: Playback, defect, P3)

Description

[Tzuhao Kuo [:kaku]]

MFR::mDemuxerInitDone is only read here:
http://searchfox.org/mozilla-central/rev/e8dd21b1673c07307068303ab3e99360c78f4d12/dom/media/MediaFormatReader.cpp#1922

And |MFR::mDemuxerInitDone| should be equivalent to |mDemuxerInitRequest.Exists()|.

I think we can just remove MFR::mDemuxerInitDone.

Comment 1

[Jean-Yves Avenard [:jya]]

It (In reply to Tzuhao Kuo [:kaku] from comment #0)
> MFR::mDemuxerInitDone is only read here:
> http://searchfox.org/mozilla-central/rev/
> e8dd21b1673c07307068303ab3e99360c78f4d12/dom/media/MediaFormatReader.cpp#1922
> 
> And |MFR::mDemuxerInitDone| should be equivalent to
> |mDemuxerInitRequest.Exists()|.
> 

It is not equivalent. 

mDemuxerInitDone indicates that the initialisation completed and succeeded. 
Checking that the request exists only give you that information, it doesn't tell you if it has finished and succeeded. 

Check the blame for this line, you will find the bug where this check was added because distinguishing both condition is inportant
> I think we can just remove MFR::mDemuxerInitDone.

Comment 2

[Tzuhao Kuo [:kaku]]

Yes, you're right. I did not consider it carefully, will close this bug.