1309620 - extension.getViews should check whether private mode matches

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect, P3)

Description

[Rob Wu [:robwu]]

Attachment: getViews-private.zip

extension.getViews returns a list of windows from the extension. This should only contain window objects that can be accessed by the caller. Pages in private browsing mode cannot access non-private pages and vice versa, so they should not appear in the list.

1. Load attached extension at about:debugging (via the Load extension button)
2. Click on the extension button.
3. -- The extension now opens a tab and shows the active URLs.
   -- For the record, there are two: _generated_background_page.html and tab.html
4. Open an private browsing window.
5. Click on the extension button to open another tab, in the private window.
6. Look at the tab content.

Expected result:
- tab.html (no background page, nor the tab.html from the other window because this is a private window).

Actual result:
- tab.html shows: Result not set, probably an error occurred. Check the console. 
- The page console shows: Error: Not allowed to define cross-origin object as property on [Object] or [Array] XrayWrapper
- The above error comes from getViews in ext-extension.js (after bug 1287007, this moves to ext-c-extension.js).


Similarly for extension/runtime.getBackgroundPage(): until split incognito mode is supported, getBackgroundPage() must return a void value.

Comment 1

[Rob Wu [:robwu]]

PS. A context.incognito property may be added in bug 1254221, so filtering DOM windows should then be quite straightforward.

Comment 2

[Rob Wu [:robwu]]

Oops. I meant bug 1309610.

Comment 4

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 5

[Shane Caraveo (:mixedpuppy)]

unable to reproduce

Comment 6

[Rob Wu [:robwu]]

Apparently fixed by bug 1319452.