1309634 - View -> Sort By key accelerators re-uses 'e' in en-US

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Dana Keeler (she/her) [:keeler]]

Under View -> Sort By, both "Date" and "Correspondents" use "e" as the key accelerator in en-US.

Comment 1

[Jorg K (CEST = GMT+2)]

Richard, can you take this on. Looks like "n" would be available for "Correspondents":
https://dxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/messenger/messenger.dtd#198

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug1309634.patch

No entity change because this is en-us specific.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8800603 [details] [diff] [review]
Bug1309634.patch

Thanks. You checked that "n" was available, right? - and that it was the best choice?
r=jorgk

Comment 4

[Richard Marti (:Paenglab)]

Yes, I checked this.

Comment 5

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/ce4a68ad627976d3036c363a46f81312e100d02e

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 8800603 [details] [diff] [review]
Bug1309634.patch

[Approval Request Comment]
User impact if declined: not always working accesskey
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Low

I checked on ESR-45 and the accesskey is wrong too.

Comment 7

[Jorg K (CEST = GMT+2)]

Aurora (TB 51):
https://hg.mozilla.org/releases/comm-aurora/rev/ba0b2f76ab2887ae561105daaefb48b5ea99986b

Comment 8

[Jorg K (CEST = GMT+2)]

Beta (TB 50):
https://hg.mozilla.org/releases/comm-beta/rev/7b9e92b32ac49bdf34135d9078e200124cfe68f0

Comment 9

[Kent James (:rkent)]

Comment on attachment 8800603 [details] [diff] [review]
Bug1309634.patch

https://hg.mozilla.org/releases/comm-esr45/rev/143cbcac3ee1