Closed Bug 1309634 Opened 5 years ago Closed 5 years ago

View -> Sort By key accelerators re-uses 'e' in en-US

Categories

(Thunderbird :: Folder and Message Lists, defect)

Product:
Thunderbird
Component:
Folder and Message Lists
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird49 wontfix, thunderbird50 fixed, thunderbird_esr4550+ fixed, thunderbird51 fixed, thunderbird52 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 52.0
Tracking Flags:
Tracking Status
thunderbird49 --- wontfix
thunderbird50 --- fixed
thunderbird_esr45 50+ fixed
thunderbird51 --- fixed
thunderbird52 --- fixed

People

(Reporter: keeler, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug1309634.patch
1.33 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-aurora+
jorgk-bmo
: approval-comm-beta+
rkent
: approval-comm-esr45+
Details | Diff | Splinter Review 
Under View -> Sort By, both "Date" and "Correspondents" use "e" as the key accelerator in en-US.
Richard, can you take this on. Looks like "n" would be available for "Correspondents":
https://dxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/messenger/messenger.dtd#198
Attached patch Bug1309634.patch — — Splinter Review 
No entity change because this is en-us specific.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8800603 - Flags: review?(jorgk)
Comment on attachment 8800603 [details] [diff] [review]
Bug1309634.patch

Thanks. You checked that "n" was available, right? - and that it was the best choice?
r=jorgk
Attachment #8800603 - Flags: review?(jorgk) → review+
Yes, I checked this.
https://hg.mozilla.org/comm-central/rev/ce4a68ad627976d3036c363a46f81312e100d02e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Comment on attachment 8800603 [details] [diff] [review]
Bug1309634.patch

[Approval Request Comment]
User impact if declined: not always working accesskey
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Low

I checked on ESR-45 and the accesskey is wrong too.
Attachment #8800603 - Flags: approval-comm-esr45?
Attachment #8800603 - Flags: approval-comm-beta?
Attachment #8800603 - Flags: approval-comm-aurora?
Attachment #8800603 - Flags: approval-comm-beta?
Attachment #8800603 - Flags: approval-comm-beta+
Attachment #8800603 - Flags: approval-comm-aurora?
Attachment #8800603 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.