130965 - Change assert to warning in nsBrowserWindow::SetFocus()

Status: RESOLVED FIXED

(Core Graveyard :: Viewer App, defect, P3)

Description

[kinmoz]

I'm sure others in layout are incredibly annoyed by this assertion that fires
and displays a dialog whenever you leave the viewer window during win32
debugging. I'd like to change the assertion to a warning.

Can I get an r= and sr= from one of you on the CC list so that I can request
drivers for a checkin?


Index: webshell/tests/viewer/nsBrowserWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/webshell/tests/viewer/nsBrowserWindow.cpp,v
retrieving revision 3.397
diff -u -r3.397 nsBrowserWindow.cpp
--- webshell/tests/viewer/nsBrowserWindow.cpp   6 Mar 2002 07:48:33 -0000
3.397
+++ webshell/tests/viewer/nsBrowserWindow.cpp   14 Mar 2002 18:59:58 -0000
@@ -408,7 +408,7 @@
 NS_IMETHODIMP nsBrowserWindow::SetFocus()
 {
    //XXX First Check In
-   NS_ASSERTION(PR_FALSE, "Not Yet Implemented");
+   NS_WARNING("Not Yet Implemented");
    return NS_OK;
 }

Comment 1

[kinmoz]

Attachment: Patch Rev 1

Attatching patch above for review and approval tracking.

Comment 2

[karnaze (gone)]

Comment on attachment 74121 [details] [diff] [review]
Patch Rev 1

r=karnaze

Comment 3

[Marc Attinasi]

Comment on attachment 74121 [details] [diff] [review]
Patch Rev 1

sr=attinasi - assuming you put this on a branch and had QA thoroughly test it,
of course ;)

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 74121 [details] [diff] [review]
Patch Rev 1

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 5

[kinmoz]

Fix checked into TRUNK:

    mozilla/webshell/tests/viewer/nsBrowserWindow.cpp  revision 3.398