Closed Bug 1309660 Opened 4 years ago Closed 4 years ago

add support for backgroundInterval

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: vjoshi)

References

Details

bug 1309125 is adding "backgroundInterval" as an attribute that can be set on the <update> line that will override how quickly or slowly Firefox downloads a MAR. We need to add support for this in the AppRelease blobs.

Robert, do we need to worry about _not_ setting this for versions of Firefox that don't support it, or will they silently ignore it?
(In reply to Ben Hearsum (:bhearsum) from comment #0)
> bug 1309125 is adding "backgroundInterval" as an attribute that can be set
> on the <update> line that will override how quickly or slowly Firefox
> downloads a MAR. We need to add support for this in the AppRelease blobs.
> 
> Robert, do we need to worry about _not_ setting this for versions of Firefox
> that don't support it, or will they silently ignore it?

Whoops, meant to needinfo
Flags: needinfo?(robert.strong.bugs)
No need to worry about it at all. If it is present for a client that doesn't support it it will just be ignored. If it isn't present for a client that does support it it will use the preference value and if that is not present it will use the default value.
Flags: needinfo?(robert.strong.bugs)
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #2)
> No need to worry about it at all. If it is present for a client that doesn't
> support it it will just be ignored. If it isn't present for a client that
> does support it it will use the preference value and if that is not present
> it will use the default value.

Excellent, this makes things much simpler!
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/1265ae9e90c3c3a19c2ecf6c7b46c4b6accd15f3
Bug 1309660 - add support for backgroundInterval (#158). r=bhearsum
Depends on: 1312772
Blocks: 1313113
This is in production, thanks Varun!
Assignee: nobody → varunj.1011
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.