130968 - SEC_TraversePermCerts is referenced but not defined

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Wan-Teh Chang]

The function SEC_TraversePermCerts is referenced by two
files (lib/jar/jarjart.c and cmd/lib/seccnames.c) but
not defined.

I don't know why we are not getting unresolved symbol
linker errors.  I found out about this problem because
the compiler warns about implicit declaration of
function SEC_TraversePermCerts (it's not declared in
any header file).

Is this a serious problem?

Comment 1

[Robert Relyea]

No, I suspect we aren't getting an error because the code that references
SEC_TraversePermCerts is dead code.

No external apps include libjar anymore (only a couple of our internal ones).

bob

Comment 2

[Wan-Teh Chang]

Changed the QA contact to Bishakha.

Comment 3

[Robert Relyea]

Setting target to 3.5 may be pushed off since it's not critical

Comment 4

[Wan-Teh Chang]

Moved to NSS 3.6, priority P3, severity trivial.

Bob, I guess the fix is not to implement SEC_TraversePermCerts
but rather to remove the references to this symbol, right?

Comment 5

[Robert Relyea]

yes, the fix would be to replace SEC_TraversePermCerts with PK11_ListCerts.

Comment 6

[Wan-Teh Chang]

Moved to target milestone 3.8 because the original
NSS 3.7 release has been renamed 3.8.

Comment 7

[Robert Relyea]

Attachment: Remove Traverse call from libjar.

Comment 8

[Wan-Teh Chang]

Comment on attachment 115951 [details] [diff] [review]
Remove Traverse call from libjar.

In jarjart.c,

>+    certs = PK11_ListCerts(PK11CertListUnique, NULL/* pwarg*/);
>+    if (certs)
>+      {
>+	for (node = CERT_LIST_HEAD(certs); !CERT_LIST_END(node,certs);
>+				node = CERT_LIST_NEXT(node))
>+           {
>+	    jar_list_cert_callback(node->cert, NULL, (void *)&ugly_list);
>+	   }
>+	CERT_DestroyCertList(certs);
>+       }
>+     else
>+       {
>+	status = SECFailure;
>+       }

The new code will never set 'status' to SECSuccess.  It is
also ignoring the return value of jar_list_cert_callback.
If 'certs' is not NULL, I think 'status' should either be
set to SECSuccess or based on the return value of
jar_list_cert_callback.

Comment 9

[Robert Relyea]

It should return SECSuccess if it finds some certs.
Ignoring the return code from the callback function emulates the same behavior
as the original Traverse function.

Comment 10

[Robert Relyea]

Attachment: Incorporate wtc's comments...

Comment 11

[Wan-Teh Chang]

Comment on attachment 116243 [details] [diff] [review]
Incorporate wtc's comments...

r=wtc.	cmd/lib/seccnames.c also needs to be fixed.

Comment 12

[Robert Relyea]

Attachment: Remove depricated '.c' file

Comment 13

[Wan-Teh Chang]

Comment on attachment 116323 [details] [diff] [review]
Remove depricated '.c' file

r=wtc.

Comment 14

[Robert Relyea]

These patches are all checked in.