1309723 - Remove DOM/voicemail and related code.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Michelangelo De Simone [Offline] [:mds]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ba53b64b127

Comment 2

[Michelangelo De Simone [Offline] [:mds]]

Attachment: Bug 1309723 - Remove DOM/voicemail and related code.

Review commit: https://reviewboard.mozilla.org/r/85706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85706/

Comment 3

[Michelangelo De Simone [Offline] [:mds]]

Ehsan, the patch also modifies something in b2g/. I'm not sure whether it's ok or not.
Also, I've left dom/mobilemessage intact as it's gonna be dealt with in bug 1310027.

Comment 4

[(no longer active)]

Comment on attachment 8800891 [details]
Bug 1309723 - Remove DOM/voicemail and related code.

https://reviewboard.mozilla.org/r/85706/#review84328

Nice!

Comment 5

[Michelangelo De Simone [Offline] [:mds]]

(In reply to :Ehsan Akhgari from comment #4)

> Nice!

Thanks!:-D

Comment 6

[Carsten Book [:Tomcat]]

has problems to apply:

warning: conflicts while merging browser/installer/package-manifest.in! (edit, then use 'hg resolve --mark') warning: conflicts while merging dom/base/Navigator.cpp! (edit, then use 'hg resolve --mark') warning: conflicts while merging dom/base/Navigator.h! (edit, then use 'hg resolve --mark') warning: conflicts while merging layout/build/nsLayoutModule.cpp! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8800891 [details]
Bug 1309723 - Remove DOM/voicemail and related code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85706/diff/1-2/

Comment 8

[Michelangelo De Simone [Offline] [:mds]]

(In reply to Carsten Book [:Tomcat] from comment #6)

> has problems to apply:

I was pretty much sure this would have happened. Sorry for the troubles :Tomcat.
Rebased and repushed on try to be sure.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71a2e2c89613
Remove DOM/voicemail and related code. r=Ehsan

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/71a2e2c89613

Comment 11

[Chris Mills [:cmills]]

Adding ddn, just to check the docs for this.

Comment 12

[Chris Mills [:cmills]]

I've made sure all the related reference pages are moved to the archive:

https://developer.mozilla.org/en-US/docs/Archive/B2G_OS/API/MozVoicemail (and child pages)
https://developer.mozilla.org/en-US/docs/Archive/B2G_OS/API/MozVoicemailEvent (and child pages)
https://developer.mozilla.org/en-US/docs/Archive/B2G_OS/API/MozVoicemailStatus (and child pages)
https://developer.mozilla.org/en-US/docs/Archive/B2G_OS/API/Navigator/mozVoicemail

And added a note to the Fx52 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/52#Changes_and_removals_3

Hope that's OK. Thanks!