Closed
Bug 1309728
Opened 8 years ago
Closed 8 years ago
ruleview checkboxes are almost invisible with light-theme
Categories
(DevTools :: Inspector: Rules, defect, P1)
DevTools
Inspector: Rules
Tracking
(firefox52 verified)
VERIFIED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | verified |
People
(Reporter: jdescottes, Assigned: ntim)
References
Details
Attachments
(2 files)
invisible-checkboxes-ruleview.png
Looks like this is a regression from Bug 1306840. When using the light-theme the ruleview checkboxes are very hard to see.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
|
||
Comment 1•8 years ago
|
||
Triaging as a P1. Tim, thanks for taking it on. Are you able to work on this now, if not maybe I can take it, I'd like this not to stay for too long in nightly.
Flags: needinfo?(ntim.bugs)
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(ntim.bugs)
|
Reporter | |
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8801361 [details] Bug 1309728 - Fix invisible rule-view checkboxes in light theme. https://reviewboard.mozilla.org/r/86130/#review84716 Works nicely with all themes, thanks!
Attachment #8801361 -
Flags: review?(jdescottes) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Thanks for the quick review!
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/23c212f90766 Fix invisible rule-view checkboxes in light theme. r=jdescottes
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/23c212f90766
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Comment 7•8 years ago
|
||
I have reproduced this bug with Nightly 52.0a1 (2016-10-12) (64-bit) on Windows 7 , 64 Bit ! This bug's fix is verified with latest Nightly Build ID 20161102030205 User Agent Mozilla/5.0 (WindowsNT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 [bugday-20161102]
|
|
Assignee | |
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•