13098 - Attachments menu in envelope is broken

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Phil Peterson]

I got a message which contains attachments. When I click on the attachments menu in the message envelope area, the button depresses, but I don't see the list of attachments, so I can't open or save them.

Comment 1

[jefft]

Accepting ... M11

Comment 2

[sol]

I think this needs to be fixed for PR1, so I added a note to the Status
Whiteboard.

Comment 3

[Phil Peterson]

ducarroz says you can't build popup menus dynamically on windows. check with
xpfe.

Comment 4

[jefft]

XUL popup indeed is disabled as far as I can tell from the cvs log of
nsWebShellWindow.cpp. This will be a blocker for me to work on Open Attachments
and Save Attachments feature.

Comment 5

[David Hyatt]

Switch to using an XP menu if you want a left-click popup. Look at the syntax
for a menu on the menu bar.  You can use that to make a left-click popup.

Comment 6

[jefft]

Thanks much. Assuming that http://www.mozilla.org/xpfe/xptoolkit/menus.html is
the document I should look into.

Comment 7

[jefft]

Dave, I think this bug should be yours. You can close down the bug once you
turned on the new xul popup stuff. Thanks,

Comment 8

[lchiang]

Phil, should this be in for Beta 1?

Comment 9

[Phil Peterson]

Yes, it's on the current B1 list.

Comment 10

[David Hyatt]

My hands have deteriorated to the point where I can no longer type.  I need
help.  If you think you can fix this bug on your own, please take it away from
me.  If you'd like to volunteer to be my hands for a specific bug, then I'll be
happy to come up to your cube and sit with you and fix the bug (assuming you
have the patience for that).

Comment 11

[Phil Peterson]

Jefft has done a workaround for this, so I think we can take it off the B1
radar. Clearing dependency and milestone (hope this is ok with you, Peter)

Comment 12

[esther]

Using 19990923 builds on win 98 I can't a small .gif attached file to display in
either IMAP or POP.  Also, for POP the system hangs when just trying to view the
message with this attachment, IMAP displays the message with the text I've typed
(no attachment) and doesn't hang.   When was the workaround implemented?

Comment 13

[Phil Peterson]

Reassigning to jefft for comment

Comment 14

[jefft]

The workaround was checked in Monday. If your are using XUL as your output for
the message displayed in your message pane (by default it is) then you should be
able to the "Save Attachment(s)" text menu on the right hand side of the message
header prior to the attachments paper clip icon. Sending messages with
attachments work for me with today's build at least for attaching work document.
You can use qatest21 account to see some of the messages which contains
attachments. Try Karen's "attach1" message and my "two more attachments" you
should be able to see the attachments list and save them to the disk. The
implementation was using menubar as suggested earlier by hyatt.

Comment 15

[jefft]

I'll try my best to figure out and turn on the popup menu. hyatt, is there any
thing I should watch out for? I know that you commented out the popup in
nsWebShellWindows.cpp. Is it save for me to uncomment it? Or the code is
obsolete? You don't need to answer these questions using keyboad. You can leave
the answer to my voice mail -- x3328. Thanks much, -- Jeff

Comment 16

[David Hyatt]

popups will work once waterson checks in a fix that we cooked up today.  examine
the personal toolbar buttons to see the proper way to do a popup.

Comment 17

[jefft]

Thanks, Dave. Chris, is there any thing I can help with?

Comment 18

[jefft]

Reassign to rhp. He wants it. :-)

Comment 19

[rhp (gone)]

The attachments menu is now operational again and closer to the spec. The hack
menu has been removed.

- rhp

Comment 20

[pmock]

Verified on Linux and Win32 under POP and IMAP.  I tested with these builds:
 Win32 commercial seamonkey build 1999-10-13-13-m11 installed on P166 Win98
 Linux commercial seamonkey build 1999-10-13-12-m11 installed on P200 RedHat 6.0
ftp://sweetlou/products/client/seamonkey/unix/linux_glibc/2.2/x86/1999-10-13-12-M11/
ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/1999-10-13-13-M11/

On Mac, there is an [PP] parity bug 16145.  There is no attachment button.
Marking this bug as verified as resolved.  The mac but is being kept tracked
separately.