Closed Bug 1309802 Opened 4 years ago Closed 4 years ago

Thousands of warning about unsupported color profile

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jya, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

Using on Ubuntu 16.04 (that uses FFmpeg 2.8)

The console is flooded with warnings like:
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla
Assignee: nobody → sotaro.ikeda.g
Attached patch patch - Supress warning (obsolete) — Splinter Review
Attachment #8800545 - Flags: review?(jyavenard)
This is when playing a H264 video btw. The value of colorspace is 2 (AVCOL_SPC_UNSPECIFIED)

Also seen when running the mediasource mochitests.
Comment on attachment 8800545 [details] [diff] [review]
patch - Supress warning

Review of attachment 8800545 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp
@@ -310,5 @@
>        case AVCOL_SPC_BT470BG:
>          b.mYUVColorSpace = YUVColorSpace::BT601;
>          break;
> -      default:
> -        NS_WARNING("Unsupported yuv color space.");

you're likely going to get some compilation warning that not all values are handled. so having a default: break is probably needed.
Attachment #8800545 - Flags: review?(jyavenard) → review+
Apply the comment.
Attachment #8800545 - Attachment is obsolete: true
Attachment #8800561 - Flags: review+
Maybe it's better to add empty AVCOL_SPC_UNSPECIFIED case but leave warning? That way it will only warn for things like BT.2020.
(In reply to kagami from comment #5)
> Maybe it's better to add empty AVCOL_SPC_UNSPECIFIED case but leave warning?
> That way it will only warn for things like BT.2020.

I am going to keep as attachment 8800561 [details] [diff] [review] in this patch. It seems enough for now.
I am going to re-visit to it in Bug 1210357.
(In reply to Sotaro Ikeda [:sotaro] from comment #7)
> I am going to re-visit to it in Bug 1210357.

Correction: 
  I am going to re-visit to it in Bug 1305907.
https://hg.mozilla.org/mozilla-central/rev/4c0c548d98c0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.