1309802 - Thousands of warning about unsupported color profile

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

Using on Ubuntu 16.04 (that uses FFmpeg 2.8)

The console is flooded with warnings like:
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314
[26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Supress warning

Comment 2

[Jean-Yves Avenard [:jya]]

This is when playing a H264 video btw. The value of colorspace is 2 (AVCOL_SPC_UNSPECIFIED)

Also seen when running the mediasource mochitests.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8800545 [details] [diff] [review]
patch - Supress warning

Review of attachment 8800545 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp
@@ -310,5 @@
>        case AVCOL_SPC_BT470BG:
>          b.mYUVColorSpace = YUVColorSpace::BT601;
>          break;
> -      default:
> -        NS_WARNING("Unsupported yuv color space.");

you're likely going to get some compilation warning that not all values are handled. so having a default: break is probably needed.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Supress warning

Apply the comment.

Comment 5

[kagami]

Maybe it's better to add empty AVCOL_SPC_UNSPECIFIED case but leave warning? That way it will only warn for things like BT.2020.

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to kagami from comment #5)
> Maybe it's better to add empty AVCOL_SPC_UNSPECIFIED case but leave warning?
> That way it will only warn for things like BT.2020.

I am going to keep as attachment 8800561 [details] [diff] [review] in this patch. It seems enough for now.

Comment 7

[Sotaro Ikeda [:sotaro]]

I am going to re-visit to it in Bug 1210357.

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)
> I am going to re-visit to it in Bug 1210357.

Correction: 
  I am going to re-visit to it in Bug 1305907.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0c548d98c0
Supress warning r=jya

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c0c548d98c0