Status
()
People
(Reporter: jya, Assigned: sotaro)
Tracking
Firefox Tracking Flags
(firefox52 fixed)
Details
Attachments
(1 attachment, 1 obsolete attachment)
|
868 bytes,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
Using on Ubuntu 16.04 (that uses FFmpeg 2.8) The console is flooded with warnings like: [26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314 [26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314 [26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314 [26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp, line 314 [26160] WARNING: Unsupported yuv color space.: file /home/jyavenard/Work/Mozilla
|
(Assignee) | |
Updated•2 years ago
|
||
Assignee: nobody → sotaro.ikeda.g
|
|
(Assignee) | |
Comment 1•2 years ago
|
||
Created attachment 8800545 [details] [diff] [review] patch - Supress warning
|
|
(Assignee) | |
Updated•2 years ago
|
||
Attachment #8800545 -
Flags: review?(jyavenard)
|
(Reporter) | |
Comment 2•2 years ago
|
||
This is when playing a H264 video btw. The value of colorspace is 2 (AVCOL_SPC_UNSPECIFIED) Also seen when running the mediasource mochitests.
|
|
(Reporter) | |
Comment 3•2 years ago
|
||
Comment on attachment 8800545 [details] [diff] [review] patch - Supress warning Review of attachment 8800545 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp @@ -310,5 @@ > case AVCOL_SPC_BT470BG: > b.mYUVColorSpace = YUVColorSpace::BT601; > break; > - default: > - NS_WARNING("Unsupported yuv color space."); you're likely going to get some compilation warning that not all values are handled. so having a default: break is probably needed.
Attachment #8800545 -
Flags: review?(jyavenard) → review+
|
|
(Assignee) | |
Comment 4•2 years ago
|
||
Created attachment 8800561 [details] [diff] [review] patch - Supress warning Apply the comment.
Attachment #8800545 -
Attachment is obsolete: true
Attachment #8800561 -
Flags: review+
Maybe it's better to add empty AVCOL_SPC_UNSPECIFIED case but leave warning? That way it will only warn for things like BT.2020.
|
|
(Assignee) | |
Comment 6•2 years ago
|
||
(In reply to kagami from comment #5) > Maybe it's better to add empty AVCOL_SPC_UNSPECIFIED case but leave warning? > That way it will only warn for things like BT.2020. I am going to keep as attachment 8800561 [details] [diff] [review] in this patch. It seems enough for now.
|
|
(Assignee) | |
Comment 7•2 years ago
|
||
I am going to re-visit to it in Bug 1210357.
|
|
(Assignee) | |
Comment 8•2 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #7) > I am going to re-visit to it in Bug 1210357. Correction: I am going to re-visit to it in Bug 1305907.
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0c548d98c0 Supress warning r=jya
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4c0c548d98c0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•