Closed Bug 1309829 Opened 8 years ago Closed 8 years ago

Remove redundant function call in nsBaseWidget::OnRenderingDeviceReset()

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: kechen, Assigned: kechen)

Details

Attachments

(2 files)

In nsBaseWidget::OnRenderingDeviceReset[1], we execute IdentifyTextureHost twice.

I think we can remove one of them.

[1] https://dxr.mozilla.org/mozilla-central/rev/22be4ae74653b25186665f22e52a50e7027fd36b/widget/nsBaseWidget.cpp#354-357
Assignee: nobody → kechen
Hi David,

Can you help me to review this patch ?

After [1], these two functions are basically doing the same task, so I think it's okay to remove one of them.

[1] https://hg.mozilla.org/releases/mozilla-aurora/rev/34df95dbc0d5
Attachment #8800587 - Flags: review?(dvander)
Comment on attachment 8800587 [details] [diff] [review]
Remove redundant IdentifyTextureHost call.

Review of attachment 8800587 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, but I'd rather keep the ClientLayerManager call than the ShadowLayerForwarder one.
Attachment #8800587 - Flags: review?(dvander) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5fd53a25098
Remove redundant IdentifyTextureHost call. r=dvander
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a5fd53a25098
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: