1309830 - nsBlockFrame::SplitLine() does not redo current line when its block-size shrinks

Status: REOPENED

(Core :: Layout: Floats, defect, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I had attempted to fix 345369-2.html [1] in bug 1291110 comment 17, but I failed to find a feasible solution.

The issue is that when nsBlockFrame::SplitLine() split some frames to its own line during reflow, the height of original line could become shorter due to those frames being split. Therefore it's possible that the original line won't intersect some of the floats now, and its inline-start position could be adjusted.  Currently, we do no redo the original line.

[1] https://dxr.mozilla.org/mozilla-central/rev/22be4ae74653b25186665f22e52a50e7027fd36b/layout/reftests/floats/reftest.list#14

Comment 1

[Brad Werth [:bradwerth]]

Bug 1466231 is handling this, perhaps in a different way than Ting-Yu diagnosed originally.

Comment 2

[Brad Werth [:bradwerth]]

The approach for Bug 1466231 has changed enough that it no longer resolves this problem. I'll take this bug since the solution will likely be closely related.

Comment 3

[Brad Werth [:bradwerth]]

Taking myself off this again to focus on other work. Sorry for the thrash.

Comment 4

[Sebastian Zartner [:sebo]]

This is the only bug left blocking the shape-outside bug 1098939, which itself is the only blocking bug for the CSS Shapes Module Level 1 (bug 1040714).
Would be great to see this fixed, so the other both can be closed, too! (And finishing another CSS module would be fantastic progress, since we just have two completed so far (see bug 1323667).

Sebastian

Comment 5

[Brad Werth [:bradwerth]]

Ting-Yu, do you want to do more shape-outside work and take this bug? If not, I'll take it back and try again.

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Brad, I'm currently busy with Bug 616436. I would be great if you can take this. Thanks!