Closed Bug 1309842 Opened 7 years ago Closed 7 years ago

Fix eslint/espree parsing errors for ignored directories in browser/

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1309842 - Fix eslint/espree parsing errors for ignored directories in browser/.
58 bytes, text/x-review-board-request
jaws
: review+
Details 
Looking at the directories we ignore for eslint, there's a few issues that cause the espree parser to fail, and as a result, we don't see the normal eslint errors when un-ignoring those directories. Hence its difficult to assess the amount of work required.

Fixing these are fairly easy, I have a patch upcoming.
Comment on attachment 8800607 [details]
Bug 1309842 - Fix eslint/espree parsing errors for ignored directories in browser/.

https://reviewboard.mozilla.org/r/85504/#review84184
Attachment #8800607 - Flags: review?(jaws) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcfc73c043c0
Fix eslint/espree parsing errors for ignored directories in browser/. r=jaws
https://hg.mozilla.org/mozilla-central/rev/dcfc73c043c0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.