1309842 - Fix eslint/espree parsing errors for ignored directories in browser/

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Banner (:standard8)]

Looking at the directories we ignore for eslint, there's a few issues that cause the espree parser to fail, and as a result, we don't see the normal eslint errors when un-ignoring those directories. Hence its difficult to assess the amount of work required.

Fixing these are fairly easy, I have a patch upcoming.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1309842 - Fix eslint/espree parsing errors for ignored directories in browser/.

Change functions definitions to generators where yield is used, and drop of non-standards if statement in catch.
List translation/cld2/cld-worker.js as ignored now, as it is a generated file.

Review commit: https://reviewboard.mozilla.org/r/85504/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85504/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8800607 [details]
Bug 1309842 - Fix eslint/espree parsing errors for ignored directories in browser/.

https://reviewboard.mozilla.org/r/85504/#review84184

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcfc73c043c0
Fix eslint/espree parsing errors for ignored directories in browser/. r=jaws

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dcfc73c043c0