Inspector should be separate in the static build

RESOLVED FIXED

Status

SeaMonkey
Build Config
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: dveditz, Assigned: Cathleen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

467 bytes, patch
hacker formerly known as seawood@netscape.com
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
In the linux static build (and possibly windows?) the inspector library is 
merged in with the others. Since this is an optional developer tool we need to 
add the makefile magic to keep it a separate shared library so it can be 
optional and not bloat the executable for people who don't want it. See bug 
128507 for additional info.

(not sure cathleen is the correct assignee)
(Reporter)

Comment 1

16 years ago
nominating... if we ship static we won't want the bloat.
Keywords: nsbeta1
(Assignee)

Comment 2

16 years ago
Created attachment 74166 [details] [diff] [review]
force inspector lib to be shared lib

I think this should do it.  With this change, libinspector.so gets build.
(Assignee)

Updated

16 years ago
Keywords: nsbeta1 → nsbeta1+
(Assignee)

Updated

16 years ago
Blocks: 128507
(Reporter)

Comment 3

16 years ago
Comment on attachment 74166 [details] [diff] [review]
force inspector lib to be shared lib

sr=dveditz
Attachment #74166 - Flags: superreview+
Comment on attachment 74166 [details] [diff] [review]
force inspector lib to be shared lib

r=cls
Attachment #74166 - Flags: review+
Comment on attachment 74166 [details] [diff] [review]
force inspector lib to be shared lib

r=cls
(Assignee)

Comment 6

16 years ago
got a verbal a= from asa
fix checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.