Add a shim to alias .contains to .includes on the array returned from DataTransfer.types in chrome code only

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

See bug 1298243 comment 33.
Blocks: 1298243
Created attachment 8800814 [details] [diff] [review]
Add a way to return frozen arrays to chrome callers with a .contains defined on them, returning the same value as .includes
Attachment #8800814 - Flags: review?(kyle)
Note that I considered hardcoding the interface/member name pair in codegen, but this seems slightly more flexible...
Comment on attachment 8800814 [details] [diff] [review]
Add a way to return frozen arrays to chrome callers with a .contains defined on them, returning the same value as .includes

Review of attachment 8800814 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, and yeah, I like this method better than hardcoding also.
Attachment #8800814 - Flags: review?(kyle) → review+

Comment 4

8 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e0d01e910bf
Add a way to return frozen arrays to chrome callers with a .contains defined on them, returning the same value as .includes.  r=qdot

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7e0d01e910bf
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.