Last Comment Bug 1309970 - Add a shim to alias .contains to .includes on the array returned from DataTransfer.types in chrome code only
: Add a shim to alias .contains to .includes on the array returned from DataTra...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: Unspecified Unspecified
-- normal (vote)
: mozilla52
Assigned To: Boris Zbarsky [:bz] (still a bit busy)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 1298243
  Show dependency treegraph
 
Reported: 2016-10-13 12:06 PDT by Boris Zbarsky [:bz] (still a bit busy)
Modified: 2016-10-14 03:07 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
fixed


Attachments
Add a way to return frozen arrays to chrome callers with a .contains defined on them, returning the same value as .includes (7.37 KB, patch)
2016-10-13 12:41 PDT, Boris Zbarsky [:bz] (still a bit busy)
kyle: review+
Details | Diff | Splinter Review

Description User image Boris Zbarsky [:bz] (still a bit busy) 2016-10-13 12:06:52 PDT
See bug 1298243 comment 33.
Comment 1 User image Boris Zbarsky [:bz] (still a bit busy) 2016-10-13 12:41:34 PDT
Created attachment 8800814 [details] [diff] [review]
Add a way to return frozen arrays to chrome callers with a .contains defined on them, returning the same value as .includes
Comment 2 User image Boris Zbarsky [:bz] (still a bit busy) 2016-10-13 12:42:25 PDT
Note that I considered hardcoding the interface/member name pair in codegen, but this seems slightly more flexible...
Comment 3 User image Kyle Machulis [:qdot] 2016-10-13 13:38:54 PDT
Comment on attachment 8800814 [details] [diff] [review]
Add a way to return frozen arrays to chrome callers with a .contains defined on them, returning the same value as .includes

Review of attachment 8800814 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, and yeah, I like this method better than hardcoding also.
Comment 4 User image Pulsebot 2016-10-13 19:14:41 PDT
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e0d01e910bf
Add a way to return frozen arrays to chrome callers with a .contains defined on them, returning the same value as .includes.  r=qdot
Comment 5 User image Carsten Book [:Tomcat] 2016-10-14 03:07:49 PDT
https://hg.mozilla.org/mozilla-central/rev/7e0d01e910bf

Note You need to log in before you can comment on or make changes to this bug.